This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-19586 Fix accessibility issues with SVG icons #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
devinbinnie
approved these changes
Oct 29, 2019
lindy65
approved these changes
Nov 5, 2019
lindy65
added
QA Review Done
Tests/Not Needed
hmhealey
added
the
4: Reviews Complete
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
* MM-19586 Use correct role for SVG icons * MM-19586 Remove duplicate IDs from SVG icons
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly removes some duplicate IDs since Devin already fixed the invalid roles for most of the icons.
Ticket Link
https://mattermost.atlassian.net/browse/MM-19586