Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Remove channel memberships when a user is removed from a team #4022

Merged
merged 12 commits into from
Nov 5, 2019
Merged

Remove channel memberships when a user is removed from a team #4022

merged 12 commits into from
Nov 5, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Oct 22, 2019

Summary

Remove channel memberships when a user is removed from a team

Ticket Link

MM-19414

Related Pull Requests

@jespino jespino added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Oct 22, 2019
@jespino jespino added this to the v5.17.0 milestone Oct 22, 2019
@jespino jespino requested a review from a team October 22, 2019 20:43
@ghost ghost requested review from cpanato and iomodo and removed request for a team October 22, 2019 20:43
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 22, 2019
@jespino jespino mentioned this pull request Oct 22, 2019
Merged
3 tasks
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 23, 2019
@srkgupta srkgupta removed their assignment Oct 24, 2019
@srkgupta srkgupta self-requested a review October 24, 2019 16:14
@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 24, 2019
srkgupta
srkgupta approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the PR instance and the issue is working fine. LGTM.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 24, 2019
@mattermod
Copy link
Contributor

Test server destroyed

iomodo
iomodo approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just linter errors to be fixed.

@cpanato cpanato added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 29, 2019
@cpanato
Copy link
Contributor

cpanato commented Oct 29, 2019

need to figure out why the build is failing

jespino added a commit to jespino/mattermost-webapp that referenced this pull request Oct 31, 2019
@jespino
cherry-picking MM-19414 mattermost#4022
3e24554
jespino added a commit to jespino/mattermost-webapp that referenced this pull request Oct 31, 2019
@jespino
cherry-picking MM-19414 mattermost#4022
8592602
@jespino jespino mentioned this pull request Oct 31, 2019
Merged
jespino added a commit that referenced this pull request Oct 31, 2019
@jespino
cherry-picking MM-19414 #4022 (#4102)
eb75779
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 31, 2019
@jespino jespino removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Nov 5, 2019
@jespino jespino merged commit dc33cec into mattermost:master Nov 5, 2019
@jespino jespino deleted the MM-19414 branch November 5, 2019 09:26
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 5, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@jespino @brewsterbhg
Remove channel memberships when a user is removed from a team (matter…
39dff49 
…most#4022)

* Remove channel memberships when a user is removed from a team

* Updating mattermost-redux

* Remove unnecesary build

* Reverting unnecesary changes

* Fixing linting errors

* fixing linting errors
@ogi-m ogi-m added the Tests/Done Release tests have been written label Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@iomodo iomodo iomodo approved these changes

@cpanato cpanato cpanato approved these changes

Assignees

@jespino jespino

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.17.0
7 participants
@jespino @mattermod @cpanato @srkgupta @iomodo @ogi-m @amyblais