This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-19506 Fix attaching files on devices with touch events #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
suggested changes
Oct 18, 2019
cpoile
approved these changes
Oct 18, 2019
sudheerDev
approved these changes
Oct 21, 2019
enahum
pushed a commit
that referenced
this pull request
Oct 22, 2019
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
…#3996) * Fix attaching files on devices with touch events * Make better test for touch event
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The actual implementation will only trigger on click event, in case of devices with touch the click event will trigger when double tapping. Here we are listening for a touch end event to trigger the same behavior as a simple mouse click.
Ticket Link
https://mattermost.atlassian.net/browse/MM-19506