MM-17477: Fix for group display name column expanding too large when …

[mkraft]

…the name wraps.

Summary

Identified by QA during the case where a group's display name is > 128 characters in the linking phase: this change fixes the styling when the name wraps.

Ticket Link

https://mattermost.atlassian.net/browse/MM-17477

[lindalumitchell]

Given the time constraints, I'm going to approve this and the other PR, and will test after merged/cherry-picked.

[amyblais]

@mkraft @lindalumitchell Is this urgent for v5.16 or can this be for v5.17?

[michaelgamble]

@mkraft is there a reason we aren't clipping the characters with an ellipses?

[lindalumitchell]

@amyblais there was also an issue with the link not working when the name was too long, so I think this probably should be for v5.16.

@mkraft can you confirm whether the display issue is separate from the functionality issue, or whether they are fixed together?

[mkraft]

@lindalumitchell This is separate; just a one-liner CSS change and not urgent.

[lindalumitchell]

Thanks @mkraft, I'm fine with pushing the display issue to v5.17; was there a separate fix for the linking issue, with the Linked/Not Linked function failing if the name is too long?

[amyblais]

mattermost/mattermost#12751

[lindalumitchell]

Ah cool, I thought that server PR was just display-related as well rather than function-related, thanks Amy.

[michaelgamble]

@lindalumitchell i couldnt figure out how to retest this to see if its been updated with my elipses suggestion or not..

[mkraft]

@michaelgamble Per your ellipsis question... are you proposing adding an an ellipsis and only displaying less than 128 characters (which is the max) of the group display name?

[michaelgamble]

yeah thats my suggestion, having it extend and overlap other columns of data or break the table visually seem like a worse aesthetic

I think there is a way to do it in CSS where the content is dynamically cut off based on the available width of the div that the content sits in with an elipses.. in my opinion that would be the best scenerio to solve this problem.

[mkraft]

@michaelgamble Is it currently extending and overlapping other columns with this fix? If so I wasn't aware of that. Also, how many characters would you have it display prior to en ellipsis?

[michaelgamble]

Last time i was able to look at a working test server with it, the overlapping is what i was seeing..

As far as the solution, it doesn't need to be a fixed character limit, you can just set the text-overflow:ellipsis; I think that will do what we want.

[lindalumitchell]

@mkraft @michaelgamble is this one still in process for v5.17? Ideally we should aim to complete and review by EOD Thursday if possible for code complete.

[mkraft]

@michaelgamble Here's the screenshot with your requested changes:

[mkraft]

@lindalumitchell This is ready for QA now.

[mattermod]

Mattermost test server updated with git commit e288c9f531eb2d759cbc1128b5baf04dd13e0650.

Access here: https://mattermost-webapp-pr-3945.test.mattermost.cloud

[lindalumitchell]

@mkraft I'm testing this, and the display issue looks good, but I still am unable to click the link to link the group with the long name (it says Link Failed), and for some reason the LDAP sync is stuck on Pending as well.

I tried the same LDAP instance on a v5.16 server and a master server, and both connected and synced without issue. So I'm not sure if there's an issue here that needs attention, or if somehow something expected is causing different behavior.

Can you take a look with a test instance of LDAP that you have and see if anything looks wrong?

[lindalumitchell]

Chatting with @mkraft and got the correct LDAP setup, and it is now connecting and syncing as expected, but linking the group with the long, truncated name is still failing.

[lindalumitchell]

Chatted more with @mkraft and it was a config issue; I replaced cn with entryUUID as the Group ID Attribute, and the long name still truncated as expected, and also I was able to link the group as expected. This looks good to me.

[mattermod]

Test server destroyed

[lindalumitchell]

@mkraft I think this is good to merge in and cherry-pick?