This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fix settings for guest MFA authentication in the admin console #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
commented
Oct 11, 2019
| @@ -3516,19 +3516,6 @@ const AdminDefinition = { | |||
| placeholder: t('admin.guest_access.whitelistedDomainsExample'), | |||
| placeholder_default: 'E.g.: "company.com, othercorp.org"', | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Is just simply a matter of ordering, it fixes the problem.
ghost
requested review from
cpoile and
sbishel
and removed request for
a team
jespino
added
2: Dev Review
srkgupta
added
Setup Cloud Test Server
|
Test server destroyed |
srkgupta
approved these changes
Oct 11, 2019
sbishel
approved these changes
Oct 11, 2019
cpoile
approved these changes
Oct 11, 2019
cpoile
added
4: Reviews Complete
mattermod
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Wicked7000
pushed a commit
to Wicked7000/mattermost-webapp
that referenced
this pull request
Oct 12, 2019
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix settings for guest MFA authentication in the admin console
Ticket Link
MM-19376