Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-18438] Fix autocomplete of channel spinning infinitely for guest user #3917

Merged
merged 1 commit into from
Oct 9, 2019
Merged

[MM-18438] Fix autocomplete of channel spinning infinitely for guest user #3917

merged 1 commit into from
Oct 9, 2019

Conversation

streamer45
Copy link
Contributor

Summary

Fixed by silently handling the case where ChannelActions.autocompleteChannels fails and just return available channels.

Ticket

https://mattermost.atlassian.net/browse/MM-18438

@streamer45 streamer45 added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 9, 2019
@streamer45 streamer45 added this to the v5.17.0 milestone Oct 9, 2019
@streamer45 streamer45 self-assigned this Oct 9, 2019
reflog
reflog approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mgdelacroix
mgdelacroix approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgdelacroix mgdelacroix removed the 2: Dev Review Requires review by a core commiter label Oct 9, 2019
ogi-m
ogi-m approved these changes Oct 9, 2019
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA will test after merging

@ogi-m ogi-m added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Oct 9, 2019
@streamer45 streamer45 merged commit 057da6d into mattermost:master Oct 9, 2019
@streamer45 streamer45 deleted the MM-18438 branch October 9, 2019 14:37
Wicked7000 pushed a commit to Wicked7000/mattermost-webapp that referenced this pull request Oct 12, 2019
@streamer45 @Wicked7000
Handle error case when autocompleting channels (mattermost#3917)
bc5711f
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 16, 2019
@amyblais amyblais modified the milestones: v5.17.0, v5.18.0 Oct 21, 2019
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 30, 2019
@amyblais amyblais modified the milestones: v5.18.0, v5.17.0 Oct 30, 2019
@amyblais amyblais removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 31, 2019
@amyblais amyblais modified the milestones: v5.17.0, v5.18.0 Oct 31, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@streamer45 @brewsterbhg
Handle error case when autocompleting channels (mattermost#3917)
8ad8d83
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 18, 2019
@ogi-m ogi-m added the Tests/Done Release tests have been written label Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees

@streamer45 streamer45

Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@streamer45 @reflog @mgdelacroix @ogi-m @amyblais