This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fixing guest being removed from other not-visible user from a channel #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mgdelacroix and
migbot
and removed request for
a team
jespino
added
CherryPick/Approved
migbot
suggested changes
Oct 9, 2019
srkgupta
approved these changes
Oct 9, 2019
srkgupta
added
QA Review Done
and removed
3: QA Review
|
@migbot Sure |
|
Done @migbot PTAL |
migbot
approved these changes
Oct 10, 2019
jespino
requested review from
reflog and
streamer45
and removed request for
mgdelacroix and
reflog
streamer45
approved these changes
Oct 11, 2019
jespino
added
4: Reviews Complete
mattermod
added
CherryPick/Done
jespino
pushed a commit
that referenced
this pull request
Oct 11, 2019
amyblais
added
Changelog/Not Needed
Wicked7000
pushed a commit
to Wicked7000/mattermost-webapp
that referenced
this pull request
Oct 12, 2019
…mattermost#3914) * Fixing guest being removed from other not-visible user from a channel * Adding tests verifying the new behavior * fixing lint errors * Addressing PR review comments * Fix linting error
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
…mattermost#3914) * Fixing guest being removed from other not-visible user from a channel * Adding tests verifying the new behavior * fixing lint errors * Addressing PR review comments * Fix linting error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a guest was removed from a channel and the user wasn't visible, it needs
to ask for the user information to confirm that the other user is no longer
visible.
Ticket Link
MM-19169