Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing problem saving config because saveConfig function has disappeared #3913

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Fixing problem saving config because saveConfig function has disappeared #3913

merged 3 commits into from
Oct 9, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Oct 9, 2019

Summary

Fixing problem saving config because saveConfig function has disappeared

Ticket Link

MM-19306

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 9, 2019
@jespino jespino added this to the v5.18.0 milestone Oct 9, 2019
@jespino jespino requested a review from ogi-m October 9, 2019 09:42
streamer45
streamer45 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Just a small typo.

components/admin_console/schema_admin_settings.jsx Outdated Show resolved Hide resolved
@reflog
Copy link
Contributor

reflog commented Oct 9, 2019

@jespino - great minds think alike: #3878

reflog
reflog approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reflog reflog mentioned this pull request Oct 9, 2019
Closed
@ogi-m ogi-m added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 9, 2019
@streamer45 streamer45 removed the 2: Dev Review Requires review by a core commiter label Oct 9, 2019
@mattermost mattermost deleted a comment from mattermod Oct 9, 2019
@mattermost mattermost deleted a comment from mattermod Oct 9, 2019
@ogi-m ogi-m added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Oct 9, 2019
ogi-m
ogi-m approved these changes Oct 9, 2019
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed on the test server 👍

@jespino jespino merged commit 43180fc into mattermost:master Oct 9, 2019
@jespino jespino deleted the MM-19306 branch October 9, 2019 13:26
@mattermod
Copy link
Contributor

Test server destroyed

@ogi-m ogi-m removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 9, 2019
Wicked7000 pushed a commit to Wicked7000/mattermost-webapp that referenced this pull request Oct 12, 2019
@jespino @Wicked7000
Fixing problem saving config because saveConfig function has disappea…
d25cb2d 
…red (mattermost#3913)

* Fixing problem saving config because saveConfig function has disappeared

* fixing typo

* fixing lint
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@jespino @brewsterbhg
Fixing problem saving config because saveConfig function has disappea…
dd5eb9b 
…red (mattermost#3913)

* Fixing problem saving config because saveConfig function has disappeared

* fixing typo

* fixing lint
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 18, 2019
@ogi-m ogi-m added the Tests/Done Release tests have been written label Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@streamer45 streamer45 streamer45 approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.18.0
6 participants
@jespino @reflog @mattermod @streamer45 @ogi-m @amyblais