This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Showing server error when trying to use a team invite link as a guest #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alifarooq0 and
levb
and removed request for
a team
jespino
added
2: Dev Review
levb
approved these changes
Oct 3, 2019
alifarooq0
reviewed
Oct 3, 2019
| @@ -130,6 +130,8 @@ export default class SignupController extends React.Component { | |||
| let serverError; | |||
| if (err.server_error_id === 'store.sql_user.save.max_accounts.app_error') { | |||
There was a problem hiding this comment.
any reason not to add an || err.server_error_id === 'api.team.add_user_to_team_from_invite.guest.app_error' here?
There was a problem hiding this comment.
Not really, maybe is more clear and easy to follow this way, but I'm not against do it with the or.
alifarooq0
approved these changes
Oct 4, 2019
srkgupta
approved these changes
Oct 9, 2019
mattermod
added
CherryPick/Done
srkgupta
added
4: Reviews Complete
amyblais
added
CherryPick/Done
Wicked7000
pushed a commit
to Wicked7000/mattermost-webapp
that referenced
this pull request
Oct 12, 2019
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Showing server error when trying to use a team invite link as a guest
Ticket Link
MM-18487
Related Pull Requests