This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-18958] Migrate components/get_android_app to TypeScript #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
LGTM. Thanks @kgeorgiou, really nice refactor of the tests :) 🎉
jespino
added
3: QA Review
|
Corresponding JIRA tickets for these have already been designated "No testing required" for QA, so no QA needed on the PR; removing label. |
lindalumitchell
added
QA Review Done
and removed
3: QA Review
jespino
added
the
4: Reviews Complete
|
Merged! thanks @kgeorgiou! 💃 |
amyblais
added
Changelog/Not Needed
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This migrates
components/get_android_appto TypeScript.Ticket Link
Fixes mattermost/mattermost#12469
Related Pull Requests
N/A