Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-18918] Migrate 'utils/server_version.jsx' and associated tests to TypeScript #3842

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

mjthomp95
Copy link
Contributor

Summary

Migrate 'utils/server_version.jsx' and associated tests to Typescript

Ticket Link

https://mattermost.atlassian.net/browse/MM-18918

Fixes mattermost/mattermost/issues/12485

@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label Oct 2, 2019
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks @mjthomp95!

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 2, 2019
@jwilander jwilander merged commit facb5f4 into mattermost:master Oct 2, 2019
@mjthomp95 mjthomp95 deleted the MM-18918 branch October 2, 2019 21:05
@hanzei hanzei added this to the v5.18.0 milestone Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
… TypeScript (mattermost#3842)

* Migrate 'utils/server_version.jsx' and tests to TypeScript

* remove undefined test
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
… TypeScript (mattermost#3842)

* Migrate 'utils/server_version.jsx' and tests to TypeScript

* remove undefined test
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
… TypeScript (mattermost#3842)

* Migrate 'utils/server_version.jsx' and tests to TypeScript

* remove undefined test
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 3, 2019
kgeorgiou pushed a commit to kgeorgiou/mattermost-webapp that referenced this pull request Oct 22, 2019
… TypeScript (mattermost#3842)

* Migrate 'utils/server_version.jsx' and tests to TypeScript

* remove undefined test
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest Tests/Not Needed Does not require new release tests
Projects
None yet
6 participants