Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Showing properly guest badge on channel group message header with full name #3832

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Showing properly guest badge on channel group message header with full name #3832

merged 1 commit into from
Oct 2, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Oct 1, 2019

Summary

Showing properly guest badge on channel group message header with full name

Ticket Link

MM-19046

@jespino jespino requested review from ogi-m and a team October 1, 2019 16:50
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 1, 2019
@ghost ghost requested review from cpanato and sbishel and removed request for a team October 1, 2019 16:50
@jespino jespino added this to the v5.16.0 milestone Oct 1, 2019
@ogi-m ogi-m added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 1, 2019
@mattermod
Copy link
Contributor

Test server destroyed

ogi-m
ogi-m approved these changes Oct 1, 2019
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the spinwick and looks good

@jespino jespino removed the 3: QA Review Requires review by a QA tester label Oct 1, 2019
@sbishel sbishel added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 2, 2019
@jespino jespino merged commit f8cf9c5 into mattermost:master Oct 2, 2019
@jespino jespino deleted the MM-19046 branch October 2, 2019 19:09
@mattermost-build mattermost-build mentioned this pull request Oct 2, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 2, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 2, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Showing properly guest badge on channel group message header with ful…
6652c8b 
…l name (mattermost#3832)
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Showing properly guest badge on channel group message header with ful…
59eb129 
…l name (mattermost#3832)
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Showing properly guest badge on channel group message header with ful…
512dc5e 
…l name (mattermost#3832)
@mickmister mickmister mentioned this pull request Oct 7, 2019
Merged
@ogi-m ogi-m added the Tests/Done Release tests have been written label Oct 15, 2019
kgeorgiou pushed a commit to kgeorgiou/mattermost-webapp that referenced this pull request Oct 22, 2019
@jespino @kgeorgiou
Showing properly guest badge on channel group message header with ful…
c6b52e4 
…l name (mattermost#3832)
@marianunez marianunez mentioned this pull request Nov 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

@sbishel sbishel sbishel approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees

@jespino jespino

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.16.0
6 participants
@jespino @mattermod @cpanato @sbishel @ogi-m @amyblais