Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Mm 18743 - MM-18795 - System console UI changes. #3764

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Mm 18743 - MM-18795 - System console UI changes. #3764

merged 3 commits into from
Sep 25, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-18795 - Updating sidebar color
MM-18743 - Updating ldap user row spacing

Ticket Link

https://mattermost.atlassian.net/browse/MM-18743
https://mattermost.atlassian.net/browse/MM-18795

@asaadmahmood asaadmahmood added this to the v5.16.0 milestone Sep 25, 2019
@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 25, 2019
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change below

sass/components/_groups.scss Outdated Show resolved Hide resolved
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino removed the 2: Dev Review Requires review by a core commiter label Sep 25, 2019
@lindy65 lindy65 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 25, 2019
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asaadmahmood - tested https://mattermost.atlassian.net/browse/MM-18795 on the spinwick and it looks good to me.

I think it's fine to test https://mattermost.atlassian.net/browse/MM-18743 on v5.16 release branch where LDAP is set up once this PR is merged.

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 25, 2019
@asaadmahmood asaadmahmood merged commit 270802b into mattermost:master Sep 25, 2019
@asaadmahmood asaadmahmood deleted the MM-18743 branch September 25, 2019 18:41
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 25, 2019
asaadmahmood pushed a commit that referenced this pull request Sep 25, 2019
* MM-18795 - Updating sidebar color

* MM-18743 - Updating ldap user row spacing

* Updating return
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 26, 2019
@stevemudie stevemudie added the Tests/Done Release tests have been written label Sep 30, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* MM-18795 - Updating sidebar color

* MM-18743 - Updating ldap user row spacing

* Updating return
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* MM-18795 - Updating sidebar color

* MM-18743 - Updating ldap user row spacing

* Updating return
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* MM-18795 - Updating sidebar color

* MM-18743 - Updating ldap user row spacing

* Updating return
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants