Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Avoid avatars to be shrinked by flexbox policies #3750

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Avoid avatars to be shrinked by flexbox policies #3750

merged 2 commits into from
Sep 24, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Sep 24, 2019

Summary

Avoid avatars to be shrinked by flexbox policies

Ticket Link

MM-18670

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 24, 2019
@jespino jespino requested a review from ogi-m September 24, 2019 13:54
@jespino jespino added this to the v5.16.0 milestone Sep 24, 2019
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 24, 2019
streamer45
streamer45 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Sep 24, 2019
asaadmahmood
asaadmahmood suggested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will actually cause an issue in the center channel as the width for the image is 32px set with some other css, but the avatar used is Avatar-lg. Can we also change the center channel profile picture avatar to Avatar-md as well?

@asaadmahmood
Copy link
Contributor

asaadmahmood commented Sep 24, 2019 •
edited
Loading

See screenshots. The image is now expanded.

Screenshot 2019-09-24 at 7 43 58 PM
Screenshot 2019-09-24 at 7 44 00 PM

@jespino
Copy link
Member Author

jespino commented Sep 24, 2019

@asaadmahmood good catch, let me check if I can find the proper solution, I guess the change of Avatar-lg to Avatar-md should be enough, but I would like to remove unneeded existing css if is possible.

@asaadmahmood
Copy link
Contributor

@jespino Yes, we should remove that css too that I have shown in that screenshot too, now that the avatar is giving it the width/heigth.

@jespino
Copy link
Member Author

jespino commented Sep 24, 2019

@asaadmahmood done

ogi-m
ogi-m approved these changes Sep 24, 2019
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA will test after it's merged

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 24, 2019
@jespino jespino merged commit 0bd4112 into mattermost:master Sep 24, 2019
@jespino jespino deleted the MM-18670 branch September 24, 2019 15:49
@mattermost-build mattermost-build mentioned this pull request Sep 24, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 24, 2019
jespino pushed a commit that referenced this pull request Sep 24, 2019
@mattermost-build @jespino
Automated cherry pick of #3750 (#3751)
d999aeb 
* Avoid avatars to be shrinked by flexbox policies

* fixing post avatar size
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 24, 2019
jwilander pushed a commit that referenced this pull request Sep 24, 2019
@jespino @jwilander
Avoid avatars to be shrinked by flexbox policies (#3750)
ae9a843 
* Avoid avatars to be shrinked by flexbox policies

* fixing post avatar size
@stevemudie stevemudie added the Tests/Done Release tests have been written label Sep 30, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Avoid avatars to be shrinked by flexbox policies (mattermost#3750)
e462289 
* Avoid avatars to be shrinked by flexbox policies

* fixing post avatar size
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Avoid avatars to be shrinked by flexbox policies (mattermost#3750)
6a8dc74 
* Avoid avatars to be shrinked by flexbox policies

* fixing post avatar size
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Avoid avatars to be shrinked by flexbox policies (mattermost#3750)
2bd0022 
* Avoid avatars to be shrinked by flexbox policies

* fixing post avatar size
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.16.0
7 participants
@jespino @asaadmahmood @streamer45 @ogi-m @stevemudie @mattermod @amyblais