This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Improving storybook for current widgets and in general #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
commented
Sep 23, 2019
| @@ -15,6 +15,8 @@ import AboutBuildModal from 'components/about_build_modal'; | |||
|
|
|||
| import Menu from 'components/widgets/menu/menu'; | |||
|
|
|||
| import MenuItemBlockableLink from './menu_item_blockable_link'; | |||
There was a problem hiding this comment.
Moving this outside the Menu widget because is too specific to this case, so makes no sense as a general menu entry type.
jespino
added
2: Dev Review
reflog
approved these changes
Sep 24, 2019
mgdelacroix
added
4: Reviews Complete
|
This PR was merged in error so will be tested post-merge for 5.18 |
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* Improving storybook components information * Adding a mattermost theme * Moving menu_item_blockable_link outside of the widgets * Upgrade to storybook 5.2.0 * Upgrade to storybook 5.2.1
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* Improving storybook components information * Adding a mattermost theme * Moving menu_item_blockable_link outside of the widgets * Upgrade to storybook 5.2.0 * Upgrade to storybook 5.2.1
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* Improving storybook components information * Adding a mattermost theme * Moving menu_item_blockable_link outside of the widgets * Upgrade to storybook 5.2.0 * Upgrade to storybook 5.2.1
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing the theme and improving the overall usage of storybook for the existing widgets.
Ticket Link
MM-18212
QA Notes
I moved the
MenuItemBlockableLinkcomponent outside of the widgets library because is too specific to be there. You can test it going to the admin console, modifying something and trying to use the admin console menu to "switch to team X"