Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing Guest labeling in manage users #3701

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Fixing Guest labeling in manage users #3701

merged 3 commits into from
Sep 23, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Sep 19, 2019

Summary

Fixing Guest labeling in manage users in the channel

Ticket Link

MM-18488

@jespino jespino requested a review from a team September 19, 2019 12:45
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 19, 2019
@jespino jespino added this to the v5.16.0 milestone Sep 19, 2019
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 19, 2019
@ghost ghost requested review from hanzei and sudheerDev and removed request for a team September 19, 2019 12:46
@hanzei hanzei requested review from devinbinnie and removed request for hanzei September 19, 2019 18:41
srkgupta
srkgupta approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will be tested once the code is merged.

@srkgupta srkgupta removed the 3: QA Review Requires review by a QA tester label Sep 20, 2019
devinbinnie
devinbinnie approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the eslint errors need to be fixed.

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 23, 2019
@jespino jespino merged commit 6be505f into mattermost:master Sep 23, 2019
@jespino jespino deleted the MM-18488 branch September 23, 2019 13:25
@mattermost-build mattermost-build mentioned this pull request Sep 23, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 23, 2019
jespino pushed a commit that referenced this pull request Sep 23, 2019
@mattermost-build @jespino
Automated cherry pick of #3701 (#3733)
e24bd57 
* Fixing Guest labeling in manage users

* Fixing linter errors
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 23, 2019
@ogi-m ogi-m added the Tests/Done Release tests have been written label Sep 24, 2019
jwilander pushed a commit that referenced this pull request Sep 24, 2019
@jespino @jwilander
Fixing Guest labeling in manage users (#3701)
aab5995 
* Fixing Guest labeling in manage users

* Fixing linter errors
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Fixing Guest labeling in manage users (mattermost#3701)
ab1f601 
* Fixing Guest labeling in manage users

* Fixing linter errors
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Fixing Guest labeling in manage users (mattermost#3701)
52b433c 
* Fixing Guest labeling in manage users

* Fixing linter errors
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Fixing Guest labeling in manage users (mattermost#3701)
913ea1d 
* Fixing Guest labeling in manage users

* Fixing linter errors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@sudheerDev sudheerDev sudheerDev approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@jespino jespino

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.16.0
7 participants
@jespino @srkgupta @sudheerDev @devinbinnie @ogi-m @mattermod @amyblais