This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fix failing test in at-mentions #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
saturninoabril
commented
Sep 18, 2019
| @@ -11,7 +11,7 @@ import users from '../../fixtures/users.json'; | |||
|
|
|||
| function setNotificationSettings(desiredSettings = {first: true, username: true, shouts: true, custom: true, customText: '@'}) { | |||
| // Navigate to settings modal | |||
| cy.toAccountSettingsModal(null, true); | |||
| cy.toAccountSettingsModal('user-1'); | |||
There was a problem hiding this comment.
Explicitly login before going into account settings
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jwilander
pushed a commit
that referenced
this pull request
Sep 24, 2019
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick test for failing E2E on at-mentions
Ticket Link
None, reported on daily Cypress test - https://community.mattermost.com/core/pl/yiwatj6efpybjyso6cuxkihb4c