Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17945 Added test coverage for addUsersToChannel #3686

Merged

Conversation

DarrellRichards
Copy link
Contributor

@DarrellRichards DarrellRichards commented Sep 17, 2019

Summary

Added Test Coverage to addUsersToChannel within the actions/channel_action.test

Ticket Link

Jira: https://mattermost.atlassian.net/browse/MM-17945

Fixes mattermost/mattermost#12002

@DarrellRichards DarrellRichards changed the title #MM-17945 Added test coverage for addUsersToChannel MM-17945 Added test coverage for addUsersToChannel Sep 17, 2019
@hanzei hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 18, 2019
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for minor request. Thanks @DarrellRichards!

actions/channel_actions.test.js Outdated Show resolved Hide resolved
@saturninoabril saturninoabril removed the 3: QA Review Requires review by a QA tester label Sep 18, 2019
@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 23, 2019
@sudheerDev sudheerDev merged commit 44f996d into mattermost:master Sep 23, 2019
@sudheerDev
Copy link
Contributor

@DarrellRichards Thanks for the contribution 👍

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 23, 2019
jwilander pushed a commit that referenced this pull request Sep 24, 2019
* Added Tests to Cover addUsersToChannel

* Update per PR request

* Update per PR request
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* Added Tests to Cover addUsersToChannel

* Update per PR request

* Update per PR request
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* Added Tests to Cover addUsersToChannel

* Update per PR request

* Update per PR request
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* Added Tests to Cover addUsersToChannel

* Update per PR request

* Update per PR request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants