This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17979 Fix for center channel beign scrollable for few plugins #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add channel-view class to body to prevent scroll
684d16f
to
4a92c28
Compare
alifarooq0
reviewed
Sep 11, 2019
saturninoabril
approved these changes
Sep 25, 2019
| expect(document.body.classList.contains('app__body')).toBe(false); | ||
| expect(document.body.classList.contains('channel-view')).toBe(false); | ||
| }); | ||
| }); |
alifarooq0
approved these changes
Sep 30, 2019
sudheerDev
pushed a commit
that referenced
this pull request
Sep 30, 2019
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…termost#3642) * MM-17979 Fix for center channel beign scrollable for few plugins * Add channel-view class to body to prevent scroll * Update tests * Fix test case names
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…termost#3642) * MM-17979 Fix for center channel beign scrollable for few plugins * Add channel-view class to body to prevent scroll * Update tests * Fix test case names
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…termost#3642) * MM-17979 Fix for center channel beign scrollable for few plugins * Add channel-view class to body to prevent scroll * Update tests * Fix test case names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was added once for #1255 but removed as it caused other issues with not beign able to scroll in help pages etc. This solution was removed #1421 as grammarly fixed it on thier end.
Now the solution here is to add the class conditionally and remove it once we leave the channel routes
Ticket Link
https://mattermost.atlassian.net/browse/MM-17979