Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-16678 Remove IE11-specific backwards compatible scrolling code #3641

Merged
merged 3 commits into from
Sep 19, 2019
Merged

MM-16678 Remove IE11-specific backwards compatible scrolling code #3641

merged 3 commits into from
Sep 19, 2019

Conversation

sudheerDev
Copy link
Contributor

Summary

  • Removed post_list_ie references and files
  • Removed isVirtListDisabled func and references
  • Removed makeCombineUserActivityFromPosts selector and tests
  • Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  • Removed scrollPostList func and references

Ticket Link

https://mattermost.atlassian.net/browse/MM-16678

@sudheerDev
MM-16678 Remove IE11-specific backwards compatible scrolling code
2cbec22 
  * Removed post_list_ie references and files
  * Removed isVirtListDisabled func and references
  * Removed makeCombineUserActivityFromPosts selector and tests
  * Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  * Removed scrollPostList func and references
@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 11, 2019
@sudheerDev sudheerDev added this to the v5.16.0 milestone Sep 11, 2019
@sudheerDev sudheerDev requested a review from a team September 11, 2019 08:52
@ghost ghost requested review from imisshtml and matterdoc and removed request for a team September 11, 2019 08:52
@sudheerDev sudheerDev requested review from devinbinnie and Willyfrog and removed request for matterdoc and imisshtml September 16, 2019 10:51
Willyfrog
Willyfrog approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devinbinnie
devinbinnie approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Willyfrog Willyfrog removed the 2: Dev Review Requires review by a core commiter label Sep 16, 2019
@lindalumitchell
Copy link
Contributor

@sudheerDev will any specific testing be needed to verify this, or is it more like general scrolling smoke tests on non-IE11, to make sure nothing regressed for other browsers?

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 17, 2019
@sudheerDev
Copy link
Contributor Author

or is it more like general scrolling smoke tests on non-IE11, to make sure nothing regressed for other browsers?

@lindalumitchell I checked the code path and it is really specifically added for IE11 so it should not cause any issues with other browsers.
Yes, to answer your question we would need a smoke test for scrolling in other browsers and probably most of them are even covered in release testing IMO

@sudheerDev sudheerDev merged commit 91b8c40 into mattermost:master Sep 19, 2019
@sudheerDev sudheerDev deleted the MM-16678 branch September 19, 2019 12:51
@mattermost-build mattermost-build mentioned this pull request Sep 19, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 19, 2019
sudheerDev pushed a commit that referenced this pull request Sep 19, 2019
@mattermost-build @sudheerDev
Automated cherry pick of #3641 (#3703)
4045fa5 
* MM-16678 Remove IE11-specific backwards compatible scrolling code

  * Removed post_list_ie references and files
  * Removed isVirtListDisabled func and references
  * Removed makeCombineUserActivityFromPosts selector and tests
  * Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  * Removed scrollPostList func and references

* Fix i18
@sudheerDev sudheerDev removed their assignment Sep 19, 2019
@lindalumitchell lindalumitchell removed the 3: QA Review Requires review by a QA tester label Sep 19, 2019
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Sep 19, 2019
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Sep 19, 2019
jwilander pushed a commit that referenced this pull request Sep 24, 2019
@sudheerDev @jwilander
MM-16678 Remove IE11-specific backwards compatible scrolling code (#3641
f88f3b4 
)

* MM-16678 Remove IE11-specific backwards compatible scrolling code

  * Removed post_list_ie references and files
  * Removed isVirtListDisabled func and references
  * Removed makeCombineUserActivityFromPosts selector and tests
  * Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  * Removed scrollPostList func and references

* Fix i18
@sudheerDev sudheerDev mentioned this pull request Sep 25, 2019
Merged
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@sudheerDev @skheria
MM-16678 Remove IE11-specific backwards compatible scrolling code (ma…
2c7aed9 
…ttermost#3641)

* MM-16678 Remove IE11-specific backwards compatible scrolling code

  * Removed post_list_ie references and files
  * Removed isVirtListDisabled func and references
  * Removed makeCombineUserActivityFromPosts selector and tests
  * Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  * Removed scrollPostList func and references

* Fix i18
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@sudheerDev @skheria
MM-16678 Remove IE11-specific backwards compatible scrolling code (ma…
e514aa2 
…ttermost#3641)

* MM-16678 Remove IE11-specific backwards compatible scrolling code

  * Removed post_list_ie references and files
  * Removed isVirtListDisabled func and references
  * Removed makeCombineUserActivityFromPosts selector and tests
  * Changed POST_LIST_SCROLL_CHANGE emit to POST_LIST_SCROLL_TO_BOTTOM as
    we no longer need to correct on instances
  * Removed scrollPostList func and references

* Fix i18
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sudheerDev @lindalumitchell @Willyfrog @devinbinnie @mattermod @amyblais