[MM-18340] Proposed fix for 'dialog not opening' bug #3617
Conversation
pbitty
changed the title
The integration_actions module was being loaded implicitly by another part of the code, and it stopped being loaded in 70bae6a. This moves it into its own module, pending a deeper refactoring.
|
/cc @lieut-data |
|
@pbitty, thanks for this -- your solution is still interesting to me. I worked around the original problem of the missing import, but it seems your solution might speak to the underlying issue better. I'm a bit swamped this week, but I'd like to revisit this. I've filed https://mattermost.atlassian.net/browse/MM-18511 linking back to this PR to investigate further. |
| import {ModalIdentifiers} from 'utils/constants.jsx'; | ||
|
|
||
| export async function openInteractiveDialog(dialog) { | ||
| if (await matchesCurrentOrNextTriggerId(dialog.trigger_id)) { |
There was a problem hiding this comment.
@lieut-data, I read your comments in #3629. I think this PR may not address the following:
* it monitors the store to modify the store: this is perhaps better handled by a saga
Since await is syntactic sugar for Promises, I believe the store.dispatch() calls still happen inside the store.subscribe() callback.
|
@hanzei @lieut-data , no problem. Thanks. I left a comment that may be relevant if you come back to this implementation. |
Summary
While working on mattermost/mattermost#12043, I came across this bug and attempted to fix it. If think this is an appropriate solution, I am happy to continue and make any necessary changes, and write the necessary tests. If not, please feel free to close it.
MM-18340
Ticket Link
https://mattermost.atlassian.net/browse/MM-18340
Related Pull Requests