This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-18139 - Add signature_url param when invoking install_from_url api #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
marianunez
reviewed
Sep 5, 2019
| @@ -555,7 +555,7 @@ export default class PluginManagement extends AdminSettings { | |||
| serverError: null, | |||
| lastMessage: null, | |||
| }); | |||
| const {error} = await this.props.actions.installPluginFromUrl(pluginDownloadUrl, null, force); | |||
| const {error} = await this.props.actions.installPluginFromUrl(pluginDownloadUrl, force); | |||
marianunez
approved these changes
Sep 5, 2019
Merged
amyblais
added
Changelog/Not Needed
marianunez
pushed a commit
that referenced
this pull request
Sep 17, 2019
* MM-17149 - Extend config.json for marketplace settings (#3503) * MM-17149 - Extend config.json for marketplace settings * Removed todo, renamed domain * Renamed MarketplaceUrl * Removed comment * Updated string names for searching * MM-17023 - Integrations Marketplace (#3492) * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Added EnableMarketplace verification to main menu * Integrating new getMarketplacePlugins from redux * Code improvements. Changed to use MarkeplacePluginsStatus from mattermost-redux * Removed unnecessary constant definition * Refactoring from PR feedback * Updated mattermost-redux commit hash to the PR for marketplace changes * Refactored to use InstalledVersion field to filter for installed plugins * Updated mm-redux hash to the feature branch pr * Updated redux in package-lock * Styling updates for marketplace modal * Updating marketplace UI * Fixed prop set in local state * Removed unused action * Minor PR feedback * Refactoring and minor fix to item link * Added error message bar when not reaching the marketplace * Minor message fix * Fixed message id but to lint build error * Fixing lint issues * Mm 18093 system console plugin enable (#3575) * MM-18093: expose plugin enable on each page Largely eliminate the `CustomPluginSettings` class by instead carefully encoding the paths to the plugin settings. Prepend a boolean setting that points at the plugin being enabled, allowing the plugin to be enabled and disabled from its own configuration page (in addition to the top level plugin management page). This also fixes a minor issue with the header and footers of plugins potentially clashing with an id (admittedly incredibly unlikely). * disable plugin settings if disabled * consistent capitalization * MM-18139 - Add signature_url param when invoking install_from_url api (#3600) * MM-18139 - Add signature_url param when invoking install_from_url api * Reverting back to plugin_download_url to preserve backwards compatibility * bumping redux version * MM-17550 - Added search in the marketplace modal (#3635) * Added search in the marketplace modal * Moved filter to getMarketplacePlugins * PR Feedback * Added Loading screen at initial load * Updated redux commit hash * Revert mm 18139 (#3637) * Added telemetry events for plugin marketplace (#3611) * Added telemetry events for plugin marketplace * Added search tracking event * Bumped debounce wait for search tracking * MM-17846: render plugin icon, if available (#3640) * MM-17846: render plugin icon, if available * s/IconURL/IconData * leverage className * linting * MM-18475 - Converge on snake_case responses from the marketplace (#3658) * Added snapshot test for marketplace modal (#3650) * Added snapshot test for marketplace modal * Fixed casing on test data * Added error banner case for modal * Moved marketplace settings below upload plugin (#3659) * Moved marketplace settings below upload plugin * Fixed admin snapshots * fix snapshots * s/integrations marketplace/plugins marketplace (#3660) * s/integrations marketplace/plugins marketplace * update more snapshots * singular * text too! * Remove search terms from diagnostics track event (#3665) * Update Admin EnableMarketplace helptext * PR Feedback * Add e2e tests * Fix snapshot * Moved server error to be handled within component state * Updated redux hash commit
marianunez
added a commit
that referenced
this pull request
Sep 17, 2019
* MM-17149 - Extend config.json for marketplace settings (#3503) * MM-17149 - Extend config.json for marketplace settings * Removed todo, renamed domain * Renamed MarketplaceUrl * Removed comment * Updated string names for searching * MM-17023 - Integrations Marketplace (#3492) * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Added EnableMarketplace verification to main menu * Integrating new getMarketplacePlugins from redux * Code improvements. Changed to use MarkeplacePluginsStatus from mattermost-redux * Removed unnecessary constant definition * Refactoring from PR feedback * Updated mattermost-redux commit hash to the PR for marketplace changes * Refactored to use InstalledVersion field to filter for installed plugins * Updated mm-redux hash to the feature branch pr * Updated redux in package-lock * Styling updates for marketplace modal * Updating marketplace UI * Fixed prop set in local state * Removed unused action * Minor PR feedback * Refactoring and minor fix to item link * Added error message bar when not reaching the marketplace * Minor message fix * Fixed message id but to lint build error * Fixing lint issues * Mm 18093 system console plugin enable (#3575) * MM-18093: expose plugin enable on each page Largely eliminate the `CustomPluginSettings` class by instead carefully encoding the paths to the plugin settings. Prepend a boolean setting that points at the plugin being enabled, allowing the plugin to be enabled and disabled from its own configuration page (in addition to the top level plugin management page). This also fixes a minor issue with the header and footers of plugins potentially clashing with an id (admittedly incredibly unlikely). * disable plugin settings if disabled * consistent capitalization * MM-18139 - Add signature_url param when invoking install_from_url api (#3600) * MM-18139 - Add signature_url param when invoking install_from_url api * Reverting back to plugin_download_url to preserve backwards compatibility * bumping redux version * MM-17550 - Added search in the marketplace modal (#3635) * Added search in the marketplace modal * Moved filter to getMarketplacePlugins * PR Feedback * Added Loading screen at initial load * Updated redux commit hash * Revert mm 18139 (#3637) * Added telemetry events for plugin marketplace (#3611) * Added telemetry events for plugin marketplace * Added search tracking event * Bumped debounce wait for search tracking * MM-17846: render plugin icon, if available (#3640) * MM-17846: render plugin icon, if available * s/IconURL/IconData * leverage className * linting * MM-18475 - Converge on snake_case responses from the marketplace (#3658) * Added snapshot test for marketplace modal (#3650) * Added snapshot test for marketplace modal * Fixed casing on test data * Added error banner case for modal * Moved marketplace settings below upload plugin (#3659) * Moved marketplace settings below upload plugin * Fixed admin snapshots * fix snapshots * s/integrations marketplace/plugins marketplace (#3660) * s/integrations marketplace/plugins marketplace * update more snapshots * singular * text too! * Remove search terms from diagnostics track event (#3665) * Update Admin EnableMarketplace helptext * PR Feedback * Add e2e tests * Fix snapshot * Moved server error to be handled within component state * Updated redux hash commit * Updated redux hash commit
jwilander
pushed a commit
that referenced
this pull request
Sep 24, 2019
* MM-17149 - Extend config.json for marketplace settings (#3503) * MM-17149 - Extend config.json for marketplace settings * Removed todo, renamed domain * Renamed MarketplaceUrl * Removed comment * Updated string names for searching * MM-17023 - Integrations Marketplace (#3492) * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Added EnableMarketplace verification to main menu * Integrating new getMarketplacePlugins from redux * Code improvements. Changed to use MarkeplacePluginsStatus from mattermost-redux * Removed unnecessary constant definition * Refactoring from PR feedback * Updated mattermost-redux commit hash to the PR for marketplace changes * Refactored to use InstalledVersion field to filter for installed plugins * Updated mm-redux hash to the feature branch pr * Updated redux in package-lock * Styling updates for marketplace modal * Updating marketplace UI * Fixed prop set in local state * Removed unused action * Minor PR feedback * Refactoring and minor fix to item link * Added error message bar when not reaching the marketplace * Minor message fix * Fixed message id but to lint build error * Fixing lint issues * Mm 18093 system console plugin enable (#3575) * MM-18093: expose plugin enable on each page Largely eliminate the `CustomPluginSettings` class by instead carefully encoding the paths to the plugin settings. Prepend a boolean setting that points at the plugin being enabled, allowing the plugin to be enabled and disabled from its own configuration page (in addition to the top level plugin management page). This also fixes a minor issue with the header and footers of plugins potentially clashing with an id (admittedly incredibly unlikely). * disable plugin settings if disabled * consistent capitalization * MM-18139 - Add signature_url param when invoking install_from_url api (#3600) * MM-18139 - Add signature_url param when invoking install_from_url api * Reverting back to plugin_download_url to preserve backwards compatibility * bumping redux version * MM-17550 - Added search in the marketplace modal (#3635) * Added search in the marketplace modal * Moved filter to getMarketplacePlugins * PR Feedback * Added Loading screen at initial load * Updated redux commit hash * Revert mm 18139 (#3637) * Added telemetry events for plugin marketplace (#3611) * Added telemetry events for plugin marketplace * Added search tracking event * Bumped debounce wait for search tracking * MM-17846: render plugin icon, if available (#3640) * MM-17846: render plugin icon, if available * s/IconURL/IconData * leverage className * linting * MM-18475 - Converge on snake_case responses from the marketplace (#3658) * Added snapshot test for marketplace modal (#3650) * Added snapshot test for marketplace modal * Fixed casing on test data * Added error banner case for modal * Moved marketplace settings below upload plugin (#3659) * Moved marketplace settings below upload plugin * Fixed admin snapshots * fix snapshots * s/integrations marketplace/plugins marketplace (#3660) * s/integrations marketplace/plugins marketplace * update more snapshots * singular * text too! * Remove search terms from diagnostics track event (#3665) * Update Admin EnableMarketplace helptext * PR Feedback * Add e2e tests * Fix snapshot * Moved server error to be handled within component state * Updated redux hash commit
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-17149 - Extend config.json for marketplace settings (mattermost#3503) * MM-17149 - Extend config.json for marketplace settings * Removed todo, renamed domain * Renamed MarketplaceUrl * Removed comment * Updated string names for searching * MM-17023 - Integrations Marketplace (mattermost#3492) * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Added EnableMarketplace verification to main menu * Integrating new getMarketplacePlugins from redux * Code improvements. Changed to use MarkeplacePluginsStatus from mattermost-redux * Removed unnecessary constant definition * Refactoring from PR feedback * Updated mattermost-redux commit hash to the PR for marketplace changes * Refactored to use InstalledVersion field to filter for installed plugins * Updated mm-redux hash to the feature branch pr * Updated redux in package-lock * Styling updates for marketplace modal * Updating marketplace UI * Fixed prop set in local state * Removed unused action * Minor PR feedback * Refactoring and minor fix to item link * Added error message bar when not reaching the marketplace * Minor message fix * Fixed message id but to lint build error * Fixing lint issues * Mm 18093 system console plugin enable (mattermost#3575) * MM-18093: expose plugin enable on each page Largely eliminate the `CustomPluginSettings` class by instead carefully encoding the paths to the plugin settings. Prepend a boolean setting that points at the plugin being enabled, allowing the plugin to be enabled and disabled from its own configuration page (in addition to the top level plugin management page). This also fixes a minor issue with the header and footers of plugins potentially clashing with an id (admittedly incredibly unlikely). * disable plugin settings if disabled * consistent capitalization * MM-18139 - Add signature_url param when invoking install_from_url api (mattermost#3600) * MM-18139 - Add signature_url param when invoking install_from_url api * Reverting back to plugin_download_url to preserve backwards compatibility * bumping redux version * MM-17550 - Added search in the marketplace modal (mattermost#3635) * Added search in the marketplace modal * Moved filter to getMarketplacePlugins * PR Feedback * Added Loading screen at initial load * Updated redux commit hash * Revert mm 18139 (mattermost#3637) * Added telemetry events for plugin marketplace (mattermost#3611) * Added telemetry events for plugin marketplace * Added search tracking event * Bumped debounce wait for search tracking * MM-17846: render plugin icon, if available (mattermost#3640) * MM-17846: render plugin icon, if available * s/IconURL/IconData * leverage className * linting * MM-18475 - Converge on snake_case responses from the marketplace (mattermost#3658) * Added snapshot test for marketplace modal (mattermost#3650) * Added snapshot test for marketplace modal * Fixed casing on test data * Added error banner case for modal * Moved marketplace settings below upload plugin (mattermost#3659) * Moved marketplace settings below upload plugin * Fixed admin snapshots * fix snapshots * s/integrations marketplace/plugins marketplace (mattermost#3660) * s/integrations marketplace/plugins marketplace * update more snapshots * singular * text too! * Remove search terms from diagnostics track event (mattermost#3665) * Update Admin EnableMarketplace helptext * PR Feedback * Add e2e tests * Fix snapshot * Moved server error to be handled within component state * Updated redux hash commit
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-17149 - Extend config.json for marketplace settings (mattermost#3503) * MM-17149 - Extend config.json for marketplace settings * Removed todo, renamed domain * Renamed MarketplaceUrl * Removed comment * Updated string names for searching * MM-17023 - Integrations Marketplace (mattermost#3492) * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Initial commit for intergrations marketplace dialog. WIP - Still pending: server integration, search and pagination * Added localization messages * Updated test snapshots * Added UI for no plugins installed case * Added UI for no plugins available in marketplace * Added error message in plugin row * Fixed error row opacity * Added missing text * Updated snapshots * Added EnableMarketplace verification to main menu * Integrating new getMarketplacePlugins from redux * Code improvements. Changed to use MarkeplacePluginsStatus from mattermost-redux * Removed unnecessary constant definition * Refactoring from PR feedback * Updated mattermost-redux commit hash to the PR for marketplace changes * Refactored to use InstalledVersion field to filter for installed plugins * Updated mm-redux hash to the feature branch pr * Updated redux in package-lock * Styling updates for marketplace modal * Updating marketplace UI * Fixed prop set in local state * Removed unused action * Minor PR feedback * Refactoring and minor fix to item link * Added error message bar when not reaching the marketplace * Minor message fix * Fixed message id but to lint build error * Fixing lint issues * Mm 18093 system console plugin enable (mattermost#3575) * MM-18093: expose plugin enable on each page Largely eliminate the `CustomPluginSettings` class by instead carefully encoding the paths to the plugin settings. Prepend a boolean setting that points at the plugin being enabled, allowing the plugin to be enabled and disabled from its own configuration page (in addition to the top level plugin management page). This also fixes a minor issue with the header and footers of plugins potentially clashing with an id (admittedly incredibly unlikely). * disable plugin settings if disabled * consistent capitalization * MM-18139 - Add signature_url param when invoking install_from_url api (mattermost#3600) * MM-18139 - Add signature_url param when invoking install_from_url api * Reverting back to plugin_download_url to preserve backwards compatibility * bumping redux version * MM-17550 - Added search in the marketplace modal (mattermost#3635) * Added search in the marketplace modal * Moved filter to getMarketplacePlugins * PR Feedback * Added Loading screen at initial load * Updated redux commit hash * Revert mm 18139 (mattermost#3637) * Added telemetry events for plugin marketplace (mattermost#3611) * Added telemetry events for plugin marketplace * Added search tracking event * Bumped debounce wait for search tracking * MM-17846: render plugin icon, if available (mattermost#3640) * MM-17846: render plugin icon, if available * s/IconURL/IconData * leverage className * linting * MM-18475 - Converge on snake_case responses from the marketplace (mattermost#3658) * Added snapshot test for marketplace modal (mattermost#3650) * Added snapshot test for marketplace modal * Fixed casing on test data * Added error banner case for modal * Moved marketplace settings below upload plugin (mattermost#3659) * Moved marketplace settings below upload plugin * Fixed admin snapshots * fix snapshots * s/integrations marketplace/plugins marketplace (mattermost#3660) * s/integrations marketplace/plugins marketplace * update more snapshots * singular * text too! * Remove search terms from diagnostics track event (mattermost#3665) * Update Admin EnableMarketplace helptext * PR Feedback * Add e2e tests * Fix snapshot * Moved server error to be handled within component state * Updated redux hash commit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pipe
SignatureUrlparam through when invokinginstallPluginFromUrlapi.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-18139
Related Pull Requests