This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Moving AdminPanel component scss code aside the component #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
ghost
requested review from
enahum and
Willyfrog
and removed request for
a team
enahum
approved these changes
Sep 3, 2019
Willyfrog
approved these changes
Sep 4, 2019
|
Do we know milestone / fix version for this one? And whether there should be any QA test steps? :) |
|
@lindalumitchell No milestone, whenever it gets merged determine the fix version. Added QA steps to the ticket. |
lindalumitchell
added
the
Setup Cloud Test Server
|
Compared new and old Teams and Groups pages, and they look good. Also smoke tested functionality on both pages, including clicking to configuration pages and back, and pagination. Removing QA Review label. |
jespino
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
lindy65
added
Tests/Not Needed
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…#3593) * Moving AdminPanel component scss code aside the component * Fix lint error
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…#3593) * Moving AdminPanel component scss code aside the component * Fix lint error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving AdminPanel component scss code aside the component
Ticket Link
MM-18205