Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing Discard changes submodal z-index on invitation modal #3573

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 30, 2019

Summary

Fixing Discard changes submodal z-index on invitation modal. The sensation was that everything was blocked, but the real problem was that the confirm modal had the wrong z-index

Ticket Link

MM-17920

@jespino jespino requested review from srkgupta and a team August 30, 2019 18:01
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 30, 2019
@jespino jespino added this to the v5.16.0 milestone Aug 30, 2019
@ghost ghost requested review from mkraft and reflog and removed request for a team August 30, 2019 18:01
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and will be tested once the code is merged into master.

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 5, 2019
@jespino jespino self-assigned this Sep 5, 2019
@jespino jespino merged commit 31a5b47 into mattermost:master Sep 5, 2019
@jespino jespino deleted the MM-17920 branch September 5, 2019 15:19
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 5, 2019
@ogi-m ogi-m added the Tests/Done Release tests have been written label Sep 24, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
6 participants