Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-16934] Add ability for channel type toggle (public/private) to go both directions #3568

Merged
merged 11 commits into from
Sep 18, 2019
Merged

[MM-16934] Add ability for channel type toggle (public/private) to go both directions #3568

merged 11 commits into from
Sep 18, 2019

Conversation

streamer45
Copy link
Contributor

Summary

Makes it possible for system administrators to make public channels private and private channels public within the new System Console > User Management > Channel Configuration page.

Ticket Link

https://mattermost.atlassian.net/browse/MM-16934

Related Pull Requests

@streamer45 streamer45 added 2: Dev Review Requires review by a core commiter Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) 3: QA Review Requires review by a QA tester labels Aug 30, 2019
@streamer45 streamer45 added this to the v5.16.0 milestone Aug 30, 2019
jespino
jespino suggested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to understand parameter, probably placed in the wrong place.

components/admin_console/team_channel_settings/channel/details/channel_details.jsx Outdated Show resolved Hide resolved
jespino
jespino suggested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous concern is addressed, but know I found another problem.

jespino
jespino suggested changes Sep 4, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems with the localization.

jespino
jespino approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streamer45 streamer45 removed the 2: Dev Review Requires review by a core commiter label Sep 17, 2019
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 17, 2019
@amyblais amyblais removed this from the v5.16.0 milestone Sep 17, 2019
@amyblais
Copy link
Member

Removed from v5.16 because it didn't make it to feature complete. Please let me know if this is important for v5.16.

@streamer45
Copy link
Contributor Author

Removed from v5.16 because it didn't make it to feature complete. Please let me know if this is important for v5.16.

cc @wiersgallak

srkgupta
srkgupta approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. Since this change requires code from multiple repositories, this will be tested once the code is merged.

@srkgupta srkgupta removed the 3: QA Review Requires review by a QA tester label Sep 18, 2019
@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Sep 18, 2019
@streamer45 streamer45 merged commit dbf0f3d into mattermost:master Sep 18, 2019
@streamer45 streamer45 deleted the MM-16934 branch September 18, 2019 12:16
@amyblais
Copy link
Member

@streamer45 Since the other PRs were already merged and the ticket is still marked for v5.16, can you help cherry-pick this?

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 18, 2019
@amyblais amyblais added this to the v5.16.0 milestone Sep 18, 2019
streamer45 added a commit that referenced this pull request Sep 18, 2019
@streamer45
[MM-16934] Add ability for channel type toggle (public/private) to go…
acf6b8b 
… both directions (#3568)

* Add confirmation modal when converting channel to public/private

* Add ability for channel type (public/private) toggle to go both directions

* Add e2e test for channel public/private toggle

* Fix some linting issues

* Simplify toggles behaviour and add test

* Add combined modal

* Fix translations and modals

* bump mattermost-redux version

(cherry picked from commit dbf0f3d)
@streamer45 streamer45 added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 18, 2019
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Sep 19, 2019
jwilander pushed a commit that referenced this pull request Sep 24, 2019
@streamer45 @jwilander
[MM-16934] Add ability for channel type toggle (public/private) to go…
d480508 
… both directions (#3568)

* Add confirmation modal when converting channel to public/private

* Add ability for channel type (public/private) toggle to go both directions

* Add e2e test for channel public/private toggle

* Fix some linting issues

* Simplify toggles behaviour and add test

* Add combined modal

* Fix translations and modals

* bump mattermost-redux version
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@streamer45 @skheria
[MM-16934] Add ability for channel type toggle (public/private) to go…
1d1f48b 
… both directions (mattermost#3568)

* Add confirmation modal when converting channel to public/private

* Add ability for channel type (public/private) toggle to go both directions

* Add e2e test for channel public/private toggle

* Fix some linting issues

* Simplify toggles behaviour and add test

* Add combined modal

* Fix translations and modals

* bump mattermost-redux version
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@streamer45 @skheria
[MM-16934] Add ability for channel type toggle (public/private) to go…
6ecf07c 
… both directions (mattermost#3568)

* Add confirmation modal when converting channel to public/private

* Add ability for channel type (public/private) toggle to go both directions

* Add e2e test for channel public/private toggle

* Fix some linting issues

* Simplify toggles behaviour and add test

* Add combined modal

* Fix translations and modals

* bump mattermost-redux version
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Oct 14, 2019
@wiersgallak wiersgallak added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@mkraft mkraft mkraft approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees

@wiersgallak wiersgallak

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Done Required documentation has been written Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.16.0
7 participants
@streamer45 @amyblais @jespino @mkraft @srkgupta @lindalumitchell @wiersgallak