This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-16683: leverage /_redirect/integrations/bots #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a subpath configuration, these links are broken. Note that I'm intentionally skipping `announcement_bar.error.site_url_gitlab.full` and `announcement_bar.error.site_url.full` since these are only displayed when the SiteURL is empty
Normally, this link is anchored to a team, but a team is not always easily known. Leverage a permalink that resolves to the default/last selected team instead.
alifarooq0
approved these changes
Aug 24, 2019
prapti
approved these changes
Sep 4, 2019
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* fix missing siteURL in various system console links In a subpath configuration, these links are broken. Note that I'm intentionally skipping `announcement_bar.error.site_url_gitlab.full` and `announcement_bar.error.site_url.full` since these are only displayed when the SiteURL is empty * MM-16683: leverage /_redirect/integrations/bots Normally, this link is anchored to a team, but a team is not always easily known. Leverage a permalink that resolves to the default/last selected team instead.
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* fix missing siteURL in various system console links In a subpath configuration, these links are broken. Note that I'm intentionally skipping `announcement_bar.error.site_url_gitlab.full` and `announcement_bar.error.site_url.full` since these are only displayed when the SiteURL is empty * MM-16683: leverage /_redirect/integrations/bots Normally, this link is anchored to a team, but a team is not always easily known. Leverage a permalink that resolves to the default/last selected team instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Normally, this link is anchored to a team, but a team is not always easily known. Leverage a permalink that resolves to the default/last selected team instead.
This change also fixes a number of missing
SiteURLinjections, breaking scenarios where a subpath is configured.Ticket Link
https://mattermost.atlassian.net/browse/MM-16683