This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17875 Guess image format before metadata is available #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
deanwhillier
approved these changes
Aug 22, 2019
bradjcoughlin
approved these changes
Aug 28, 2019
mattermod
added
AutomatedCherryPick
and removed
CherryPick/Approved
amyblais
added
Changelog/Done
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SVGs disabled, there's a brief window when you make a post containing an SVG image link where the SVG might be rendered because the server hasn't told the client that the image is an SVG yet. We can't fix this in all cases without the client attempting to load the image itself, so trying to guess the type of image from the URL is our next best option.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17875