This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17653 Remove metadata call for youtube links #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
sudheerDev
added
CherryPick/Approved
mattermod
removed
the
Setup Cloud Test Server
sudheerDev
added
the
Setup Cloud Test Server
sudheerDev
added
Setup Cloud Test Server
| @@ -3529,6 +3529,5 @@ | |||
| "widgets.users_emails_input.loading": "Loading", | |||
| "widgets.users_emails_input.no_user_found_matching": "No one found matching **{text}**, type email address", | |||
| "widgets.users_emails_input.valid_email": "Add **{email}**", | |||
| "yourcomputer": "Your computer", | |||
| "youtube_video.notFound": "Video not found" | |||
There was a problem hiding this comment.
Was curious on this one so I tested with youtube link with available and unavailable video (only by changing the last character):
- post this (available) link --> https://www.youtube.com/watch?v=EW9rvhRnP04
- then (not available) link --> https://www.youtube.com/watch?v=EW9rvhRnP05
On master/5.14, second post showed unavailable thumbnail placeholder from youtube (probably expected but not entirely sure as I was expecting a message saying "Video not found")
On this PR, thumbnails shown as if both videos are available (clicking on second post reveals that the video is unavailable)
There was a problem hiding this comment.
Interesting. The thumbnail populated is from opengraph data so it must have returned so, i don't think this would be a bug we should fix here in webapp. In any case let me check and file a ticket for the bug
There was a problem hiding this comment.
@saturninoabril Seems related to how opengraph provides data. Weird it happens for that link. I tried couple of other links and if it is not a valid youtube link all you see is the link as a message as there will be no metadata.
@hmhealey Quick thoughts? Should we be creating a ticket for this?
hmhealey
suggested changes
Aug 23, 2019
Co-Authored-By: Harrison Healey <[email protected]>
Co-Authored-By: Harrison Healey <[email protected]>
hmhealey
approved these changes
Aug 26, 2019
saturninoabril
removed
2: Dev Review
saturninoabril
added
the
4: Reviews Complete
mattermod
added
AutomatedCherryPick
and removed
CherryPick/Approved
sudheerDev
pushed a commit
that referenced
this pull request
Sep 2, 2019
* MM-17653 Remove metadata call for youtube links * Fix lint * Fix in8 issue * Add fallback for image url * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Fix review comments * Update snapshots
amyblais
added
Changelog/Done
lieut-data
added a commit
that referenced
this pull request
Sep 10, 2019
#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
lieut-data
added a commit
that referenced
this pull request
Sep 10, 2019
#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
hanzei
pushed a commit
that referenced
this pull request
Sep 11, 2019
#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Sep 11, 2019
mattermost#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
hanzei
pushed a commit
that referenced
this pull request
Sep 11, 2019
#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-17653 Remove metadata call for youtube links * Fix lint * Fix in8 issue * Add fallback for image url * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Fix review comments * Update snapshots
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
mattermost#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-17653 Remove metadata call for youtube links * Fix lint * Fix in8 issue * Add fallback for image url * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Update components/youtube_video/youtube_video.jsx Co-Authored-By: Harrison Healey <[email protected]> * Fix review comments * Update snapshots
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
mattermost#3493 unintentionally removed the import of `actions/integration_actions`, which defined a side effect necessary to the correct functioning of interactive dialogs. I've relocated this somewhere that is more intentionally imported, and commented details as to the issues with this code block. I'm not explicitly fixing the issues right now, and I'm not sure if I can unit test this, so I'm just restoring the import for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the a API call made for youtube links and consumes data from metadata to remove scroll pop
Ticket Link
https://mattermost.atlassian.net/browse/MM-17653