This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-17786] Handle window focus events (a11y_controller.js) #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure that focus events resulting from the window regaining focus don’t inadvertently trigger a11y keyboard-related updates
migbot
approved these changes
Aug 19, 2019
|
Okay for QA to test post-merge. Removing QA Review label. |
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
- ensure that focus events resulting from the window regaining focus don’t inadvertently trigger a11y keyboard-related updates
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
- ensure that focus events resulting from the window regaining focus don’t inadvertently trigger a11y keyboard-related updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the a11ycontroller.js to keep track of window focus so that it doesn't inadvertently make a11y visual updates when the windows comes back into focus again.
The problem was that once the window came back into focus, the element that last had focus received a focus event again and since that event wasn't triggered by a mouse click, the a11y_controller assumed it was a legit focus event and highlighted the element.
Test Steps:
Expected: There should be no visual updates to the post (i.e. the post should not receive an a11y focus outline.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17786