This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17752 Fix channel_updated WS event not dispatching #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
added
2: Dev Review
|
I didn't realize there was already a ticket for this. I already submitted a PR for it earlier Funny that our fixes are almost identical though |
|
haha nice. Déjà vu. Maybe I should start a similar discussion i did on @hmhealey's PR 😂 |
|
Wow, it even looks like we both went through the same things with trying to test it |
amyblais
removed
the
CherryPick/Approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function was updated to be a redux action but we were still calling it normally.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17752