This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8172 Fix sign-up page #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
approved these changes
Nov 21, 2017
MusikPolice
approved these changes
Nov 21, 2017
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm assuming this had something to do with the client dependencies updating and some things not playing well together, but for some reason the way the
queryprop was getting set was causing havoc between react-router and react-intl.I just simplified to pass the query parameters with
location.searchwhich will be blank if there are no query parameters and have the query needed if set.Ticket Link
https://mattermost.atlassian.net/browse/PLT-8172