Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-17390] Rate limited posts fail to load threads #3449

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Aug 14, 2019

Summary

  • Rate-limited posts are batched, and those posts skip the completePostReceived path, which includes getting the post's root. If the user then clicks on the thread, they would receive the message:
    image
  • This fix uses the same strategy as the getProfilesAndStatusesForPosts function, which is also run for the list of rate-limited posts.

Ticket Link

Related Pull Requests

@cpoile cpoile added the 2: Dev Review Requires review by a core commiter label Aug 14, 2019
@cpoile cpoile added this to the v5.15.0 milestone Aug 14, 2019
@cpoile cpoile changed the title * fix for batched posts not loading threads [MM-17390] Rate limited posts fail to load threads Aug 14, 2019
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy!

@hmhealey hmhealey added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) 4: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels Aug 15, 2019
@cpoile cpoile removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 16, 2019
@cpoile
Copy link
Member Author

cpoile commented Aug 16, 2019

Removing cherry-pick because this is for 5.15 not 5.14

@cpoile cpoile removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Aug 16, 2019
@cpoile cpoile merged commit b672770 into mattermost:master Aug 16, 2019
@cpoile cpoile deleted the MM-17390 branch August 16, 2019 17:42
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 19, 2019
@amyblais
Copy link
Member

@cpoile Please help cherry-pick to v5.15.

cpoile added a commit to cpoile/mattermost-webapp that referenced this pull request Aug 19, 2019
* * fix for batched posts not loading threads

* * PR comments (to the redux portion)

* * fixing tests

* updating redux hash

(cherry picked from commit b672770)
@cpoile
Copy link
Member Author

cpoile commented Aug 19, 2019

@amyblais done: #3485

hmhealey pushed a commit that referenced this pull request Aug 20, 2019
* * fix for batched posts not loading threads

* * PR comments (to the redux portion)

* * fixing tests

* updating redux hash

(cherry picked from commit b672770)
@cpoile cpoile mentioned this pull request Aug 20, 2019
@amyblais amyblais added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 20, 2019
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Aug 20, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* * fix for batched posts not loading threads

* * PR comments (to the redux portion)

* * fixing tests

* updating redux hash
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
* * fix for batched posts not loading threads

* * PR comments (to the redux portion)

* * fixing tests

* updating redux hash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
4 participants