This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Add generation of model/emoji_data.go to make-emojis script
#3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is used by make-emojis in order to overwrite the server emoji_data.go file in case is defined
Emoji aliases seem to have duplicates and that doesn't work in the case of the emoji_data.go because you can't have duplicated keys in a map literal: `duplicate key "blonde_woman_light_skin_tone" in map literal`
ethervoid
changed the title
model/emoji_data.go to make-emojis script
Added test to check wheter a name for a cusomt icon already exists as a system icon
hmhealey
suggested changes
Aug 13, 2019
|
@hmhealey changes made :) Also I added an E2E test |
|
Seems like the |
hmhealey
approved these changes
Aug 15, 2019
|
I tried to restart the build where it got stuck, but if that doesn't work, it might help to merge in the latest master branch. We've had some infrastructure changes lately, so this branch might be caught in the middle of them |
|
@hmhealey now seems to be working hehehe |
mkraft
approved these changes
Aug 23, 2019
hmhealey
added
4: Reviews Complete
|
Thanks again for the change, @ethervoid! Just waiting for this to rebuild, and then we should be good to merge it |
lindy65
removed
the
4: Reviews Complete
amyblais
added
Changelog/Not Needed
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…most#3429) * Build emoji_data.go file using make-emojis scripts mattermost/mattermost#8566 * Add SERVER_DIR environment variable This variable is used by make-emojis in order to overwrite the server emoji_data.go file in case is defined * Remove duplicity in the emoji_data.go file Emoji aliases seem to have duplicates and that doesn't work in the case of the emoji_data.go because you can't have duplicated keys in a map literal: `duplicate key "blonde_woman_light_skin_tone" in map literal` * Fix typo in the comments * Added E2E test for custom emojis backend Added test to check wheter a name for a cusomt icon already exists as a system icon * Fix typo introduced in the Makefile Co-Authored-By: Harrison Healey <[email protected]> * Generate the emoji_data.go file into the root folder * Move the emoji_data.go file to the server folder instead of copy * Fix typo in the emoji_data.go output message
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…most#3429) * Build emoji_data.go file using make-emojis scripts mattermost/mattermost#8566 * Add SERVER_DIR environment variable This variable is used by make-emojis in order to overwrite the server emoji_data.go file in case is defined * Remove duplicity in the emoji_data.go file Emoji aliases seem to have duplicates and that doesn't work in the case of the emoji_data.go because you can't have duplicated keys in a map literal: `duplicate key "blonde_woman_light_skin_tone" in map literal` * Fix typo in the comments * Added E2E test for custom emojis backend Added test to check wheter a name for a cusomt icon already exists as a system icon * Fix typo introduced in the Makefile Co-Authored-By: Harrison Healey <[email protected]> * Generate the emoji_data.go file into the root folder * Move the emoji_data.go file to the server folder instead of copy * Fix typo in the emoji_data.go output message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the generation of the
emoji_data.gofile into theutils\serverfolder and it also adds the possibility to override the current file in the server folder.Ticket Link
Fixes mattermost/mattermost#8566
Related Pull Requests
None