This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17652 - Very long email addresses overlap with Role column on LDAP group sync warning modal #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
approved these changes
Aug 12, 2019
|
Okay for QA to test this post-merge. Removing QA Review label. |
gabrieljackson
approved these changes
Aug 12, 2019
michaelgamble
pushed a commit
to michaelgamble/mattermost-webapp
that referenced
this pull request
Aug 13, 2019
…termost#3412) * fixed long emails display in users-to-be-removed modal * snapshots
jespino
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Added the guest badge to existing bot badge class * invitation flow guest badge alignment fixes * Load statuses when opening channel member list from header (#3394) * MM-17622 - Updating menu wrapper (#3399) * MM-17622 - Updating menu wrapper * Removing cosnole * Updating webhook spacing * Revert "Updating webhook spacing" This reverts commit d4a0e77. * MM-17600 - Updating file upload (setting picture) (#3391) * MM-17552 - Preventing settings update on cancel (#3383) * MM-17552 - Preventing settings update on cancel * Updating test * Updating test * MM-16730: e2e test for replying to an older message (#3312) * [MM-17094] Spacebar now activates add button when focused on multiselect (#3344) * [MM-17094] Spacebar now activates add button when focused on multiselect * Changed space checking logic to a util function * Removed interchangeability between CTRL and CMD (#3322) Not needed and is affecting CMD+~ shortcuts on Safari for switching between multiple open windows. * MM-17487 - Updating plugin dropdown alignment (#3401) * MM-17671 Permalink does not render posts in IE11 (#3410) * Use loadPostsAround for loading posts in permalink view * MM-17485 Fix for missing messages on socket reconn for only once visited channel (#3396) * If we have the timestamp of the last time we called since API we use that to decide if we have to use that or the last posts timestamp based on socket disconnect timestamp * Issue: if we never called since API i.e the second visit to a channel then lastGetPosts state in redux state will not exist so we basically are calling since API after reconnect with the last post in channel which can be wrong as on reconnect we add new posts to the postsInChannel state * Solution: Dispatch RECEIVED_POSTS_FOR_CHANNEL_AT_TIME for unreads if we are at the latest so this way we will have a timestamp in the state of lastGetPosts. If posts are not recent then we dont need to worry because the subsequent visit to the channel will be making a call to load last 30 posts * Showing with correct colors fullname and nick name in invite users autocomplete (#3374) * MM-17672 - Updating flex css for header (#3415) * MM-17672 - Updating flex css for header * Updating header css * Updating flex pixels * Using tabSelectsValue and removing unnused component (#3343) * Using tabSelectsValue and removing unnused component * Fixing tests * Removing unnused i18n strings * Updating webhooks css (#3409) * Fixing users autocomplete search in the guests invitation modal (#3388) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration (#3346) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration * Capitalizing all multi-factor strings * Updating snapshots * Revert "Capitalizing all multi-factor strings" This reverts commit a94d92f. * Revert "Updating snapshots" This reverts commit da237ef. * Capitalizing the correct strings * rearrange custom color specs (#3375) * MM-17652 - Very long email addresses overlap with Role column o… (#3412) * fixed long emails display in users-to-be-removed modal * snapshots * MM-17690 - Updating language select functionality (#3421) * Reorganize elastic search tests to not use as much nesting (#3423) * MM-17686 - Adjusting auto focus for settings section on expand (#3385) * [MM-17581] Focused container of profile picture settings instead of first input * Updating settings max functionality * MM-17691 - Updating picture component (#3422) * MM-17119: Updates LDAP id attribute config help text to outline option for Active Directory. (#3405) * Fixing strange behavior on blur (#3387) * Lower cases some words in translation. (#3393)
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…termost#3412) * fixed long emails display in users-to-be-removed modal * snapshots
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* Added the guest badge to existing bot badge class * invitation flow guest badge alignment fixes * Load statuses when opening channel member list from header (mattermost#3394) * MM-17622 - Updating menu wrapper (mattermost#3399) * MM-17622 - Updating menu wrapper * Removing cosnole * Updating webhook spacing * Revert "Updating webhook spacing" This reverts commit d4a0e77. * MM-17600 - Updating file upload (setting picture) (mattermost#3391) * MM-17552 - Preventing settings update on cancel (mattermost#3383) * MM-17552 - Preventing settings update on cancel * Updating test * Updating test * MM-16730: e2e test for replying to an older message (mattermost#3312) * [MM-17094] Spacebar now activates add button when focused on multiselect (mattermost#3344) * [MM-17094] Spacebar now activates add button when focused on multiselect * Changed space checking logic to a util function * Removed interchangeability between CTRL and CMD (mattermost#3322) Not needed and is affecting CMD+~ shortcuts on Safari for switching between multiple open windows. * MM-17487 - Updating plugin dropdown alignment (mattermost#3401) * MM-17671 Permalink does not render posts in IE11 (mattermost#3410) * Use loadPostsAround for loading posts in permalink view * MM-17485 Fix for missing messages on socket reconn for only once visited channel (mattermost#3396) * If we have the timestamp of the last time we called since API we use that to decide if we have to use that or the last posts timestamp based on socket disconnect timestamp * Issue: if we never called since API i.e the second visit to a channel then lastGetPosts state in redux state will not exist so we basically are calling since API after reconnect with the last post in channel which can be wrong as on reconnect we add new posts to the postsInChannel state * Solution: Dispatch RECEIVED_POSTS_FOR_CHANNEL_AT_TIME for unreads if we are at the latest so this way we will have a timestamp in the state of lastGetPosts. If posts are not recent then we dont need to worry because the subsequent visit to the channel will be making a call to load last 30 posts * Showing with correct colors fullname and nick name in invite users autocomplete (mattermost#3374) * MM-17672 - Updating flex css for header (mattermost#3415) * MM-17672 - Updating flex css for header * Updating header css * Updating flex pixels * Using tabSelectsValue and removing unnused component (mattermost#3343) * Using tabSelectsValue and removing unnused component * Fixing tests * Removing unnused i18n strings * Updating webhooks css (mattermost#3409) * Fixing users autocomplete search in the guests invitation modal (mattermost#3388) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration (mattermost#3346) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration * Capitalizing all multi-factor strings * Updating snapshots * Revert "Capitalizing all multi-factor strings" This reverts commit a94d92f. * Revert "Updating snapshots" This reverts commit da237ef. * Capitalizing the correct strings * rearrange custom color specs (mattermost#3375) * MM-17652 - Very long email addresses overlap with Role column o… (mattermost#3412) * fixed long emails display in users-to-be-removed modal * snapshots * MM-17690 - Updating language select functionality (mattermost#3421) * Reorganize elastic search tests to not use as much nesting (mattermost#3423) * MM-17686 - Adjusting auto focus for settings section on expand (mattermost#3385) * [MM-17581] Focused container of profile picture settings instead of first input * Updating settings max functionality * MM-17691 - Updating picture component (mattermost#3422) * MM-17119: Updates LDAP id attribute config help text to outline option for Active Directory. (mattermost#3405) * Fixing strange behavior on blur (mattermost#3387) * Lower cases some words in translation. (mattermost#3393)
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…termost#3412) * fixed long emails display in users-to-be-removed modal * snapshots
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* Added the guest badge to existing bot badge class * invitation flow guest badge alignment fixes * Load statuses when opening channel member list from header (mattermost#3394) * MM-17622 - Updating menu wrapper (mattermost#3399) * MM-17622 - Updating menu wrapper * Removing cosnole * Updating webhook spacing * Revert "Updating webhook spacing" This reverts commit d4a0e77. * MM-17600 - Updating file upload (setting picture) (mattermost#3391) * MM-17552 - Preventing settings update on cancel (mattermost#3383) * MM-17552 - Preventing settings update on cancel * Updating test * Updating test * MM-16730: e2e test for replying to an older message (mattermost#3312) * [MM-17094] Spacebar now activates add button when focused on multiselect (mattermost#3344) * [MM-17094] Spacebar now activates add button when focused on multiselect * Changed space checking logic to a util function * Removed interchangeability between CTRL and CMD (mattermost#3322) Not needed and is affecting CMD+~ shortcuts on Safari for switching between multiple open windows. * MM-17487 - Updating plugin dropdown alignment (mattermost#3401) * MM-17671 Permalink does not render posts in IE11 (mattermost#3410) * Use loadPostsAround for loading posts in permalink view * MM-17485 Fix for missing messages on socket reconn for only once visited channel (mattermost#3396) * If we have the timestamp of the last time we called since API we use that to decide if we have to use that or the last posts timestamp based on socket disconnect timestamp * Issue: if we never called since API i.e the second visit to a channel then lastGetPosts state in redux state will not exist so we basically are calling since API after reconnect with the last post in channel which can be wrong as on reconnect we add new posts to the postsInChannel state * Solution: Dispatch RECEIVED_POSTS_FOR_CHANNEL_AT_TIME for unreads if we are at the latest so this way we will have a timestamp in the state of lastGetPosts. If posts are not recent then we dont need to worry because the subsequent visit to the channel will be making a call to load last 30 posts * Showing with correct colors fullname and nick name in invite users autocomplete (mattermost#3374) * MM-17672 - Updating flex css for header (mattermost#3415) * MM-17672 - Updating flex css for header * Updating header css * Updating flex pixels * Using tabSelectsValue and removing unnused component (mattermost#3343) * Using tabSelectsValue and removing unnused component * Fixing tests * Removing unnused i18n strings * Updating webhooks css (mattermost#3409) * Fixing users autocomplete search in the guests invitation modal (mattermost#3388) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration (mattermost#3346) * Showing correct text on MFA disabled/not-enforced on Guest accounts configuration * Capitalizing all multi-factor strings * Updating snapshots * Revert "Capitalizing all multi-factor strings" This reverts commit a94d92f. * Revert "Updating snapshots" This reverts commit da237ef. * Capitalizing the correct strings * rearrange custom color specs (mattermost#3375) * MM-17652 - Very long email addresses overlap with Role column o… (mattermost#3412) * fixed long emails display in users-to-be-removed modal * snapshots * MM-17690 - Updating language select functionality (mattermost#3421) * Reorganize elastic search tests to not use as much nesting (mattermost#3423) * MM-17686 - Adjusting auto focus for settings section on expand (mattermost#3385) * [MM-17581] Focused container of profile picture settings instead of first input * Updating settings max functionality * MM-17691 - Updating picture component (mattermost#3422) * MM-17119: Updates LDAP id attribute config help text to outline option for Active Directory. (mattermost#3405) * Fixing strange behavior on blur (mattermost#3387) * Lower cases some words in translation. (mattermost#3393)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in the warning modal that appears when users will be removed from a team or channel on LDAP sync, very long email addresses overlap with the Role column.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-17652