Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Changing translation key as suggested in PR #3336 #3370

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 6, 2019

Summary

Changing translation key as suggested in PR #3336

Ticket Link

MM-17199

Related Pull Requests

PR #3336

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 6, 2019
@jespino jespino added this to the v5.16.0 milestone Aug 6, 2019
@srkgupta
Copy link
Contributor

srkgupta commented Aug 6, 2019

Looks good. Does not requires QA to perform testing since these are used in unit tests only. Removing the QA Review label.

@srkgupta srkgupta removed their request for review August 6, 2019 10:23
@srkgupta srkgupta added Tests/Not Needed Does not require new release tests and removed 3: QA Review Requires review by a QA tester labels Aug 6, 2019
@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 6, 2019
@mickmister mickmister merged commit 3ef2b09 into mattermost:master Aug 6, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 6, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
…st#3370)

* Changing translation key as suggested in PR mattermost#3336

* Reordering properly the translation key
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
…st#3370)

* Changing translation key as suggested in PR mattermost#3336

* Reordering properly the translation key
@srkgupta srkgupta added the Tests/Done Release tests have been written label Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants