Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Add classes for mobile dividers #335

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Add classes for mobile dividers #335

merged 2 commits into from
Nov 24, 2017

Conversation

csduarte
Copy link
Contributor

Summary

Remove specific management settings based on hardcoded configs

cc @dmeza

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@jasonblais jasonblais added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Nov 20, 2017
@jasonblais
Copy link
Contributor

@asaadmahmood Please help review?

@asaadmahmood
Copy link
Contributor

@csduarte Needs a rebase.

@dmeza dmeza force-pushed the bash-25_remove-management-settings branch from a5c149a to 29e2499 Compare November 22, 2017 02:36
@dmeza
Copy link
Contributor

dmeza commented Nov 22, 2017

@asaadmahmood rebased to latest from master.

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Nov 23, 2017
@jasonblais
Copy link
Contributor

@dmeza Sorry, looks like the build fails and as a result the test server doesn't build successfully. Can you try run make check-style and make test to check for errors?

@jasonblais jasonblais added the Awaiting Submitter Action Blocked on the author label Nov 23, 2017
miguelespinoza and others added 2 commits November 22, 2017 23:06
@miguelespinoza
Add classes for mobile dividers
119de79 
Remove specific management settings based on hardcoded configs
Regenerate test snapshot based on changes: tests/components/__snapsho…
952904c 
…ts__/user_settings_display.test.jsx.snap
@dmeza dmeza force-pushed the bash-25_remove-management-settings branch from e6ee472 to 952904c Compare November 23, 2017 04:06
@dmeza
Copy link
Contributor

dmeza commented Nov 23, 2017

@jasonblais @asaadmahmood rebased to latest and re-generated snapshot. Everything is green now.

@jasonblais jasonblais removed Awaiting Submitter Action Blocked on the author Setup Old Test Server Triggers the creation of a test server labels Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Nov 23, 2017
asaadmahmood
asaadmahmood approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label Nov 23, 2017
@jasonblais jasonblais removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@mattermost mattermost deleted a comment from mattermod Nov 23, 2017
@crspeller crspeller merged commit 2963830 into mattermost:master Nov 24, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 27, 2017
@esethna esethna added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 4, 2017
@dmeza dmeza deleted the bash-25_remove-management-settings branch December 7, 2018 18:28
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@enahum @hmhealey
getPostIdsInChannel selector (#335)
94783f0
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@enahum @jwilander
getPostIdsInChannel selector (#335)
4f36c29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crspeller crspeller crspeller approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
8 participants
@csduarte @jasonblais @asaadmahmood @dmeza @crspeller @esethna @lindalumitchell @miguelespinoza