Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17334: Better handling of counter of success/error invitation texts #3345

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 2, 2019

Summary

Now only is shown the texts when they are more than 0, besides it fixes a pluralization bug that was there.

Ticket Link

MM-17334

@jespino jespino requested review from srkgupta, wiersgallak and a team August 2, 2019 09:44
@jespino jespino added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 2, 2019
@ghost ghost requested review from DSchalla and jfrerich and removed request for a team August 2, 2019 09:44
return (
<FormattedMarkdownMessage
id='invitation_modal.confirm.members_subtitle_without_sent_and_not_sent'
defaultMessage='No invitation sent'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiersgallak this string is new, maybe you want to decide to tune it a bit. Anyway this shouldn't happen, but just in case I added that code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jespino would this happen because of an error? Trying to determine what might trigger so I can better help with wording. The header already has "Invitations not sent" so I'd like to be a little more explicit if possible with this message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't happen using the current interface, In theory it would happen if you don't add any user or email in the form and click "Invite" but for that cases, the button just doesn't work, so It can't happen.

@srkgupta
Copy link
Contributor

srkgupta commented Aug 2, 2019

This will be tested as part of the Guest Account feature of 5.16 release. Removing the QA Review label.

@srkgupta srkgupta removed the 3: QA Review Requires review by a QA tester label Aug 2, 2019
@srkgupta srkgupta removed their request for review August 2, 2019 10:07
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wiersgallak wiersgallak added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Aug 7, 2019
@jespino jespino merged commit 7df81c6 into mattermost:master Aug 8, 2019
@jespino jespino deleted the MM-17334 branch August 8, 2019 08:54
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 8, 2019
@ogi-m ogi-m added the Tests/Done Release tests have been written label Sep 18, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants