Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17383 - check removed users on sync toggle #3320

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

reflog
Copy link
Contributor

@reflog reflog commented Jul 31, 2019

Summary

When toggling sync for channel - the list of removed users should be refreshed

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-17383

@reflog reflog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jul 31, 2019
@reflog reflog added this to the v5.14.0 milestone Jul 31, 2019
@lindalumitchell lindalumitchell removed the 3: QA Review Requires review by a QA tester label Jul 31, 2019
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);
}
});
const result = await actions.membersMinusGroupMembers(channelID, groups.map((g) => g.id));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 31, 2019
@jespino jespino merged commit b97a292 into mattermost:master Jul 31, 2019
@reflog
Copy link
Contributor Author

reflog commented Jul 31, 2019

/cherry-pick release-5.14

reflog added a commit that referenced this pull request Aug 1, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 5, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Aug 7, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request AutomatedCherryPick Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants