Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Get channelType from initial props in NewChannelFlow #331

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Get channelType from initial props in NewChannelFlow #331

merged 1 commit into from
Nov 21, 2017

Conversation

csduarte
Copy link
Contributor

Summary

Get channelType from initial props in NewChannelFlow

Cc @dmeza

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label Nov 20, 2017
@jasonblais
Copy link
Contributor

@jwilander @hmhealey Let me know if a PM should test something in the channel creation flow.

@jwilander
Copy link
Member

LGTM but needs a rebase

@dmeza dmeza force-pushed the BASH-16_get-channel-type-from-initial-props branch from f847ef0 to 5b54176 Compare November 21, 2017 14:57
@dmeza
Copy link
Contributor

dmeza commented Nov 21, 2017

@jwilander rebased to the latest from master.

@hmhealey hmhealey merged commit f661b74 into mattermost:master Nov 21, 2017
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Nov 21, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 27, 2017
@esethna esethna added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 4, 2017
@dmeza dmeza deleted the BASH-16_get-channel-type-from-initial-props branch December 7, 2018 18:29
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@enahum @hmhealey
Ensure serverId (diagnosticId) is always sent to segment (#331)
92c9b25
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@enahum
Ensure serverId (diagnosticId) is always sent to segment (#331)
d0b4cdf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
8 participants
@csduarte @jasonblais @jwilander @dmeza @hmhealey @esethna @lindalumitchell @miguelespinoza