Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

add config option to hide tutorial screens #325

Merged
merged 1 commit into from
Jan 2, 2018
Merged

add config option to hide tutorial screens #325

merged 1 commit into from
Jan 2, 2018

Conversation

csduarte
Copy link
Contributor

Summary

Enable tutorial screen with EnableTutorial property
Here’s the PR for the server: mattermost/mattermost#7840

cc @dmeza

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@dmeza dmeza mentioned this pull request Nov 20, 2017
Merged
7 tasks
@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from 2701687 to f24bf0a Compare November 20, 2017 21:17
@jasonblais jasonblais added 1: PM Review Requires review by a product manager Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Setup Old Test Server Triggers the creation of a test server labels Nov 20, 2017
@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Nov 20, 2017
@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from f24bf0a to 955d73f Compare November 23, 2017 22:29
@dmeza
Copy link
Contributor

dmeza commented Nov 23, 2017

@crspeller @esethna rebased to latest and fixed conflicts.

@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from 955d73f to ebea5ce Compare December 5, 2017 19:04
@dmeza
Copy link
Contributor

dmeza commented Dec 5, 2017

@jwilander @esethna rebased and tested that server is running properly. Also rebased server PR: mattermost/mattermost#7840

@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from ebea5ce to 25912d6 Compare December 7, 2017 16:32
@esethna esethna removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Dec 11, 2017
@mattermost mattermost deleted a comment from mattermod Dec 11, 2017
@mattermost mattermost deleted a comment from mattermod Dec 11, 2017
@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Dec 11, 2017
@esethna
Copy link
Contributor

esethna commented Dec 11, 2017

@jwilander can you please help flip the config setting on the spinmint so the tutorial is disabled?

@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from 25912d6 to d440203 Compare December 13, 2017 17:12
@jwilander
Copy link
Member

Flipped EnableTutorial to false

@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from d440203 to cd9e519 Compare December 18, 2017 21:22
@dmeza dmeza force-pushed the BASH-4_hide-tutorial-screens branch from cd9e519 to 3ba4e60 Compare December 18, 2017 21:49
@dmeza
Copy link
Contributor

dmeza commented Dec 18, 2017

@esethna @jwilander there were conflicts because of changes:

  • to move logic to redux: components/create_post/create_post.jsx
  • to move this component to it's own folder: components/channel_view/index.js
    rebased to latest and fixed conflicts.

@mattermost mattermost deleted a comment from mattermod Dec 21, 2017
@mattermost mattermost deleted a comment from mattermod Dec 21, 2017
@esethna esethna added 2: Dev Review Requires review by a core commiter and removed Setup Old Test Server Triggers the creation of a test server 1: PM Review Requires review by a product manager labels Dec 21, 2017
esethna
esethna approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks JW. @dmeza looks good!

@esethna esethna added this to the v4.6.0 milestone Dec 21, 2017
@esethna esethna removed their assignment Dec 22, 2017
@crspeller crspeller merged commit b9303b5 into mattermost:master Jan 2, 2018
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 4, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Jan 4, 2018
sudheerDev pushed a commit to sudheerDev/mattermost-webapp that referenced this pull request Jan 4, 2018
@csduarte
add config option to hide tutorial screens (mattermost#325)
f0af71d
dmeza pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Jan 9, 2018
@csduarte
add config option to hide tutorial screens (mattermost#325)
ce600d4
dmeza pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Jan 15, 2018
@csduarte
add config option to hide tutorial screens (mattermost#325)
8aa2ac0
dmeza pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Jan 15, 2018
@csduarte
add config option to hide tutorial screens (mattermost#325)
0bb01b7
@dmeza dmeza deleted the BASH-4_hide-tutorial-screens branch December 7, 2018 18:28
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@sudheerDev @hmhealey
Fix eslint config for callExpression indentaion. (#325)
b554687
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@sudheerDev @hmhealey
Fix eslint config for callExpression indentaion. (#325)
10938b7
@giuesposbit giuesposbit mentioned this pull request Feb 3, 2024
Open
@DSchalla DSchalla mentioned this pull request Feb 3, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@crspeller crspeller crspeller approved these changes

@esethna esethna esethna approved these changes

@mkraft mkraft Awaiting requested review from mkraft

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.
8 participants
@csduarte @dmeza @esethna @jwilander @crspeller @jasonblais @lindalumitchell @miguelespinoza