This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
E2E: add post-verification on Cypress task that the request is successfully completed #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
commented
Jul 8, 2019
| const baseUrl = Cypress.config('baseUrl'); | ||
|
|
||
| cy.task('postMessageAs', {sender, message, channelId, rootId, createAt, baseUrl}).its('status').should('be.equal', 201); | ||
| }); |
There was a problem hiding this comment.
@thekiiingbob I reverted this code which you've introduced before and then was removed by me. When I removed it before, for some reason, I've got some issue and I thought it's about Cypress task inside Cypress command. I think I'm wrong as I can't repro the issue when I reverted it now.
saturninoabril
commented
Jul 8, 2019
| const baseUrl = Cypress.config('baseUrl'); | ||
|
|
||
| cy.task('externalRequest', {baseUrl, user, method, path, data}).its('status').should('be.equal', 200); | ||
| }); |
There was a problem hiding this comment.
I don't think these commands could be part of api_commands or ui_commands, and so I added those to new task_commands.js. Feel free to comment/recommend, especially the filename.
thekiiingbob
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
E2E: add post-verification on Cypress task that the request is successfully completed by wrapping those tasks into commands.
By doing so, Cypress awaits in a certain default period of time that the (http) request is indeed successful before actually doing/verifying next step. This prevents flakiness due to timing issue especially when dealing with network request.
Ticket Link
n/a