Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14977 Add bi-directional with loading of last unread post #3049

Merged
merged 10 commits into from
Jul 9, 2019
Merged

MM-14977 Add bi-directional with loading of last unread post #3049

merged 10 commits into from
Jul 9, 2019

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Jul 3, 2019 •
edited
Loading

Summary

  • Add a virtlist prop correctScrollToBottom which will be used for auto correcting scroll position if at bottom. The value of this prop will be true if all latest posts in the channel are loaded.
  • Use unread API for calling posts on first visit of the channel
  • Use new selector for selecting posts based on timestamp last visited at to the channel for unread view
  • Use the flag of recent in state to determine if latest posts are loaded in the view to remove the loaded for more recent messages.

Ticket Link

MM-11504

Related Pull Requests

https://mattermost.atlassian.net/browse/MM-11504

@sudheerDev sudheerDev mentioned this pull request Jul 3, 2019
Closed
5 tasks
@sudheerDev sudheerDev added Work in Progress Not yet ready for review 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Jul 3, 2019
@sudheerDev sudheerDev added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Jul 5, 2019
@sudheerDev sudheerDev added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Jul 5, 2019
@sudheerDev sudheerDev added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Jul 5, 2019
@sudheerDev
Preevnt loading auto load of posts when postList does not exist
ff7bb45 
prevent loading older posts when a callback is in place
Fix range
Sync posts only if postListIds exist
Sync posts only if lastPostTimestamp exists
@sudheerDev sudheerDev removed the Setup Old Test Server Triggers the creation of a test server label Jul 8, 2019
@sudheerDev sudheerDev requested a review from migbot July 8, 2019 11:35
@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter Setup Old Test Server Triggers the creation of a test server and removed Work in Progress Not yet ready for review labels Jul 8, 2019
sudheerDev
sudheerDev commented Jul 8, 2019
View reviewed changes
package.json
@@ -84,7 +84,7 @@
"copy-webpack-plugin": "5.0.3",
"cross-env": "5.2.0",
"css-loader": "2.1.1",
"enzyme": "3.9.0",
"enzyme": "3.10.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading enzyme because of enzymejs/enzyme#2020 which was needed for adding couple of test cases and also fix https://mattermost.atlassian.net/browse/MM-15837.

@esethna esethna removed the request for review from enahum July 8, 2019 18:58
esethna
esethna approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did live testing with ST, moving to dev review so this can go through QA on daily

@sudheerDev sudheerDev removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Jul 8, 2019
@sudheerDev
Change variable and state names for unread chunk and timestamp reference
fa343a8 
Use the new util func for selecting unread chunk
Remove the check for loading posts when calling loadPosts again
hmhealey
hmhealey suggested changes Jul 9, 2019
View reviewed changes
actions/views/channel.js Outdated Show resolved Hide resolved
actions/views/channel.js Outdated Show resolved Hide resolved
components/suggestion/at_mention_provider/at_mention_provider.test.jsx Outdated Show resolved Hide resolved
@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 9, 2019
@hmhealey hmhealey merged commit 3652f10 into mattermost:master Jul 9, 2019
@sudheerDev sudheerDev deleted the MM-14977 branch July 9, 2019 22:56
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@migbot migbot migbot approved these changes

@hmhealey hmhealey hmhealey approved these changes

@esethna esethna esethna approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
5 participants
@sudheerDev @migbot @hmhealey @esethna @amyblais