Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-16704 Move cypress folder into new e2e folder #3044

Merged
merged 3 commits into from
Jul 3, 2019
Merged

MM-16704 Move cypress folder into new e2e folder #3044

merged 3 commits into from
Jul 3, 2019

Conversation

saturninoabril
Copy link
Member

Summary

Moved "/cypress" folder into new "/e2e" folder

  • so that costly download/installation of Cypress binary/dependencies will be done when running E2E test only; not during Webapp build or similar process.
  • to isolate dependencies related to Cypress, e.g. in the future, we'll add express package for webhook server.
  • to better structure the E2E folder and not pollute the main webapp folder

Other changes:

  • remove Cypress test retries (which I added recently) as it's actually not helping. Failing tests are consistent on first fail until retries
  • added ESLint overrides and remove unnecessary disabling per file
  • updated .gitignore due to this change

To do once merge:

  • will update E2E docs
  • will update shared pipelines for daily tests

Ticket Link

Jira ticket: MM-16704

@saturninoabril saturninoabril added the 2: Dev Review Requires review by a core commiter label Jul 2, 2019
hmhealey
hmhealey approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I definitely felt the pain of downloading Cypress on bad internet a few times

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 3, 2019
@saturninoabril saturninoabril merged commit 6d5d09c into mattermost:master Jul 3, 2019
@saturninoabril saturninoabril deleted the MM-16704 branch July 3, 2019 14:00
@saturninoabril saturninoabril mentioned this pull request Jul 3, 2019
Merged
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thekiiingbob thekiiingbob thekiiingbob approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees

@saturninoabril saturninoabril

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
4 participants
@saturninoabril @thekiiingbob @hmhealey @amyblais