This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
E2E: Fix failing tests on account_settings specs #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
commented
Jun 28, 2019
| @@ -18,7 +18,7 @@ describe('Account Settings > Display > Message Display', () => { | |||
|
|
|||
| after(() => { | |||
| // Revert setting so it does not impact other tests | |||
| cy.changeMessageDisplaySetting('STANDARD'); | |||
| cy.apiSaveMessageDisplayPreference('clean'); | |||
There was a problem hiding this comment.
Just use the API to reset preference.
saturninoabril
commented
Jun 28, 2019
| @@ -117,9 +117,6 @@ describe('AS14318 Theme Colors - Color Picker', () => { | |||
|
|
|||
| describe('Custom - Sidebar styles target output change', () => { | |||
| it('should take effect each custom color in Channel View', () => { | |||
| // * Check Sidebar Header Text color change after saving | |||
| cy.get('#accountSettingsModalLabel').should('have.css', 'color', 'rgb(129, 65, 65)'); | |||
There was a problem hiding this comment.
The preceding test already tested this. It's failing since the preceding also closes the account settings modal.
saturninoabril
commented
Jun 28, 2019
| @@ -14,7 +14,4 @@ import 'cypress-plugin-retries'; | |||
| // Add login cookies to whitelist to preserve it | |||
| beforeEach(() => { | |||
| Cypress.Cookies.preserveOnce('MMAUTHTOKEN', 'MMUSERID', 'MMCSRF'); | |||
|
|
|||
| cy.apiUpdateConfig({TeamSettings: {MaxUsersPerTeam: 500}}); | |||
There was a problem hiding this comment.
This is causing to conflict whenever the spec file is logging in as another user since cy.apiUpdateConfig logged in as sysadmin.
cpanato
approved these changes
Jun 28, 2019
thekiiingbob
approved these changes
Jun 28, 2019
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix failing tests on account_settings specs
Ticket Link
none