This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fix failing test on search specs #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,8 +237,8 @@ describe('SF15699 Search Date Filter', () => { | |||
| searchAndValidate(`before:${secondDateEarly.query} in:town-square ${timestamp}`, [firstMessage]); | |||
| }); | |||
|
|
|||
| it('can be used in conjunction with "from:"', function() { | |||
There was a problem hiding this comment.
@saturninoabril Were these causing problems?
There was a problem hiding this comment.
Actually the issue is this.newAdmin being undefined which I think is due to nested describe and the scope of doing so (not really sure). Change to arrow function is for consistency only.
saturninoabril
added
Work in Progress
thekiiingbob
approved these changes
Jun 28, 2019
cpanato
approved these changes
Jul 2, 2019
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix failing test on search specs
Ticket Link
none