Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-16393 - Cleaning up mobile header #3021

Merged
merged 2 commits into from
Jul 1, 2019
Merged

MM-16393 - Cleaning up mobile header #3021

merged 2 commits into from
Jul 1, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-16393 - Cleaning up mobile header, and making status icon conditional

Ticket Link

https://mattermost.atlassian.net/browse/MM-16393

@asaadmahmood asaadmahmood added the 2: Dev Review Requires review by a core commiter label Jun 26, 2019
@asaadmahmood asaadmahmood added this to the v5.14.0 milestone Jun 26, 2019
@enahum enahum requested review from deanwhillier and removed request for enahum June 26, 2019 16:24
saturninoabril
saturninoabril approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Test should be added to MobileChannelHeaderDropdown but when I tried, it's complicated. I guess this channel_header_dropdown needs to separate into smaller components (desktop, browser, mobile) for it to be testable.

@asaadmahmood asaadmahmood requested review from saturninoabril and jespino and removed request for deanwhillier June 30, 2019 15:41
jespino
jespino approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 1, 2019
@jespino jespino merged commit efe0eab into mattermost:master Jul 1, 2019
@asaadmahmood asaadmahmood deleted the MM-16393 branch July 2, 2019 04:23
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 5, 2019
@jgilliam17 jgilliam17 added the Tests/Not Needed Does not require new release tests label Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.14.0
5 participants
@asaadmahmood @jespino @saturninoabril @amyblais @jgilliam17