Fix another batch of failing e2e tests #3014
Conversation
| if (siteName) { | ||
| document.title = siteName; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is failing on signup_spec since the document title is hardcoded to "Mattermost". Instead of removing "document title" check on /signup page, apply here the same implementation on /login page.
| // Disable other auth options | ||
| const newSettings = { | ||
| Office365Settings: {Enable: false}, | ||
| LdapSettings: {Enable: false}, |
There was a problem hiding this comment.
This is disabling the auth options we're using in the test server. I'm thinking to disable that on the test server config so that we'll not worry in doing this during local dev. But I'll leave it as is for the moment.
| }); | ||
| // * Verify that HTML Content is correct | ||
| cy.getLastPostId().then((postId) => { | ||
| cy.get(`#postMessageText_${postId}`, {timeout: TIMEOUTS.MEDIUM}).should('have.html', expectedHtml); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Markdown tests for text and in-line images were separated. Intention is to separate the spec group in preparation for parallel testing.
| cy.task('postMessageAs', {sender, message, channelId, createAt}). | ||
| its('status'). | ||
| should('be.equal', 201); | ||
| }); |
There was a problem hiding this comment.
I removed this due to some Cypress priority when running a task; needed to find a way to better handle getting baseUrl. Besides, I found this confusing to include in api_command. I'm hoping to limit adding command in this file only to those with direct implementation of https://api.mattermost.com/.
There was a problem hiding this comment.
This is fine, I think we need to refactor our custom commands a bit. Added a note for our automation meeting to discuss.
| @@ -14,5 +14,7 @@ import 'cypress-plugin-retries'; | |||
| // Add login cookies to whitelist to preserve it | |||
| beforeEach(() => { | |||
| Cypress.Cookies.preserveOnce('MMAUTHTOKEN', 'MMUSERID', 'MMCSRF'); | |||
|
|
|||
| cy.apiUpdateConfig({TeamSettings: {MaxUsersPerTeam: 500}}); | |||
There was a problem hiding this comment.
This is good to have so we can re-use existing DB state without resetting.
| cy.task('postMessageAs', {sender, message, channelId, createAt}). | ||
| its('status'). | ||
| should('be.equal', 201); | ||
| }); |
There was a problem hiding this comment.
This is fine, I think we need to refactor our custom commands a bit. Added a note for our automation meeting to discuss.
amyblais
added
Changelog/Not Needed
Summary
Fix another batch of failing e2e tests
Ticket Link
none