MM-14868 Team Admin can use Next button to page through list in Manage Members #2990
Conversation
| cy.loginAsNewUser(); | ||
| }); | ||
|
|
||
| it('TS14868 Team Admin can use Next button to page through list in Manage Members', async () => { |
There was a problem hiding this comment.
I removed the async in today's PR.
|
I submitted todays PR on the branch MM-14868-try2 |
|
ok learning more and more from the recommendations! Brought in the changes to the original PR here. |
There was a problem hiding this comment.
Thanks for the update, please see comments - #2990 (comment)
|
@patterns Does this pass for you locally? As it's currently written, it fails for me. |
|
oops, had to do another commit to fix the lint warnings |
|
@thekiiingbob For me, yes it passes. After the 60+1 feedback, I even added the "make nuke" to my steps before doing commits. Maybe my steps are still missing something. Right now I do: a) dev; b) cypress; c) repeat; d) make stop; e) make nuke; f) make run-server; g) make stop-server; h) make test-data; i) make run; j) cypress; k) git commit. When I run cypress, I'm doing it in isolation with: npm run cypress:run -- --spec=cypress/integration/team/teammates_pagination_spec.js --headed --no-exit |
|
@patterns Great work with the clean up, just have a few other suggestions. Thanks! |
hanzei
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Summary
E2E Cypress test to page through the team members list. Besides the test, new IDs are added to the Searchable_User_List (Prev/Next buttons and total member count label) component. A batch-join helper function is also added to the API commands support file.
The test has some steps that may need some explanation: a) The MaxUsersPerTeam setting must be greater than 60; b) The available test users must be greater than 60; c) The /teams/_id/members/batch API allows 20 in one request, so we break the whole team into chunks of 20.
Ticket Link
Fixes mattermost/mattermost#10544
Related Pull Requests
N/A