This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-16152: always focus RHS on SELECT_POST #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, we'd refactor focus to be an entity we can directly manipulate in a reducer, but that's a non-trivial refactoring. For now, I'm capturing the timestamp of the last `SELECT_POST` and using that within the component to decide when to ignore/effect a focus of the RHS textbox, given that we already track the blur timestamp.
lieut-data
commented
Jun 19, 2019
| @@ -251,7 +256,7 @@ export default class CreateComment extends React.PureComponent { | |||
| this.scrollToBottom(); | |||
| } | |||
|
|
|||
| if (prevProps.rootId !== this.props.rootId) { | |||
| if (prevProps.rootId !== this.props.rootId || this.props.selectedPostFocussedAt > this.lastBlurAt) { | |||
There was a problem hiding this comment.
This is the crux of the change.
hmhealey
approved these changes
Jun 20, 2019
lieut-data
requested review from
deanwhillier
and removed request for
mgdelacroix
…us-rhs-on-select-post
deanwhillier
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ideally, we'd refactor focus to be an entity we can directly manipulate in a reducer, but that's a non-trivial refactoring. For now, I'm capturing the timestamp of the last
SELECT_POSTand using that within the component to decide when to ignore/effect a focus of the RHS textbox, given that we already track the blur timestamp.Ticket Link
https://mattermost.atlassian.net/browse/MM-16152