This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fix failing E2E by adding required header when logging in #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
approved these changes
Jun 19, 2019
saturninoabril
commented
Jun 19, 2019
| }); | ||
| } | ||
|
|
||
| // Add user to several teams by default | ||
| teamsToAdd.forEach((team) => { |
There was a problem hiding this comment.
This is throwing error in some test. Seems that this line is being called asap and not awaiting from the teamsResponse above.
thekiiingbob
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
E2E test failed by 90%. It's due to the recent change on server that requires additional header to return cookies.
Ticket Link
none